Bug 2156961 (ITP-rust-difftastic) - Review Request: rust-difftastic - Structural diff that understands syntax
Summary: Review Request: rust-difftastic - Structural diff that understands syntax
Keywords:
Status: CLOSED ERRATA
Alias: ITP-rust-difftastic
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2103419 2156960 2156962 2156964 2158280
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-29 22:43 UTC by Michel Lind
Modified: 2023-01-10 02:49 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-08 01:20:09 UTC
Type: Bug
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-12-29 22:43:23 UTC
Spec URL: https://salimma.fedorapeople.org/rust-difftastic.spec
SRPM URL: https://salimma.fedorapeople.org/rust-difftastic-0.39.0-1.fc37.src.rpm

Description:
Structural diff that understands syntax.

Comment 1 Davide Cavalca 2023-01-04 23:04:50 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 2 Michel Lind 2023-01-04 23:13:49 UTC
Thanks!

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 19s 
⬢ [fedora-toolbox:37] ❯ set -gx C difftastic

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) 
⬢ [fedora-toolbox:37] ❯ set -gx B 2156961

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) 
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B
https://pagure.io/releng/fedora-scm-requests/issue/50251

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 5s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9
https://pagure.io/releng/fedora-scm-requests/issue/50252

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 4s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel8
https://pagure.io/releng/fedora-scm-requests/issue/50253

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 6s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/50254
https://pagure.io/releng/fedora-scm-requests/issue/50255

Comment 3 Gwyn Ciesla 2023-01-05 15:21:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-difftastic

Comment 4 Fedora Update System 2023-01-06 19:21:15 UTC
FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

Comment 5 Fedora Update System 2023-01-07 01:28:41 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-01-07 03:11:30 UTC
FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067

Comment 7 Fedora Update System 2023-01-07 03:13:01 UTC
FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3

Comment 8 Fedora Update System 2023-01-08 01:20:09 UTC
FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-01-08 01:28:49 UTC
FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-01-09 21:30:40 UTC
FEDORA-EPEL-2023-d6cbf9aae7 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-d6cbf9aae7

Comment 11 Fedora Update System 2023-01-10 02:17:23 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-01-10 02:49:12 UTC
FEDORA-EPEL-2023-d6cbf9aae7 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.