Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.0-1.fc16.src.rpm Description: This package provides various stream wrappers.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.1-1.fc16.src.rpm
Created attachment 595422 [details] php-horde-Horde-Stream-Wrapper-review.txt Generated by fedora-review 0.1.3
SHOULD: Use %{pear_name} where possible Consider adding %{pear_channel} MUST: [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [!]: MUST Requires correct, justified where necessary. BuildRequires and Requires same version of pear, according to package.xml BuildRequires: php-pear >= 1:1.7.0 Requires: php-pear >= 1:1.7.0 Also add php-common >= 5.2.0 (waiting for a better provides in php) [!]: MUST Package must own all directories that it creates. Missing %{pear_phpdir}/Horde %{pear_phpdir}/Horde/Stream %{pear_docdir}/Horde_Stream_Wrapper
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.1-2.fc16.src.rpm
[!]: MUST Package must own all directories that it creates. Missing %{pear_phpdir}/Horde And you should, of course remove (included in previous) %{pear_phpdir}/Horde/Stream %{pear_phpdir}/Horde/Stream/Wrapper Please use macro everywhere, see %postun and %files It's probably enough to only %doc %{pear_docdir}/%{pear_name} Note : "localized" php.ini is use less in fedora (date.timezone defined in pear wrapper), I haven't check in EL.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.1-3.fc16.src.rpm
Blockers fixed. == APPROVED ==
New Package SCM Request ======================= Package Name: php-horde-Horde-Stream-Wrapper Short Description: This package provides various stream wrappers for Horde Owners: nb Branches: el6 f16 f17 InitialCC:
Git done (by process-git-requests).