Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=82a0662b5376fe1a90612ed85628670c902a43d3;path=/libjpeg/ SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-libjpeg-6b-5.fc9.src.rpm Description: MinGW Windows Libjpeg library Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW
SRPM and SPEC links seem incorrect. Could you please update them? I will take care about review.
Here are the correct URLs for this package: Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libjpeg/mingw32-libjpeg.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-libjpeg-6b-6.fc10.src.rpm
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/libjpeg/mingw32-libjpeg.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-libjpeg-6b-7.fc11.src.rpm * Fri Jan 23 2009 Richard W.M. Jones <rjones> - 6b-7 - Disable static libraries. - Use _smp_mflags. - Update for new libtool 2. - +BR mingw32-dlfcn. - Added documentation (README includes the license).
Adam, will you take this review?
(In reply to comment #4) > Adam, will you take this review? yes, of course. Sorry for late response, I lost this review in my "working queue". Review: source files match upstream: YES package meets naming and versioning guidelines: YES specfile is properly named, is cleanly written and uses macros consistently: YES dist tag is present: YES build root is correct: YES license field matches the actual license: YES license is open source-compatible. YES latest version is being packaged: YES BuildRequires are proper: YES compiler flags are appropriate: YES %clean is present: YES package builds in mock (Rawhide/x86_64): YES rpmlint is silent: NO but errors are ok for mingw32 package final provides and requires look sane: NO owns the directories it creates: YES no duplicates in %files: YES file permissions are appropriate: YES code, not content: YES ----------------------------------------------------------- Currently I see one problem - win32 binaries are installed: /usr/i686-pc-mingw32/sys-root/mingw/bin/cjpeg /usr/i686-pc-mingw32/sys-root/mingw/bin/djpeg /usr/i686-pc-mingw32/sys-root/mingw/bin/jpegtran /usr/i686-pc-mingw32/sys-root/mingw/bin/rdjpgcom /usr/i686-pc-mingw32/sys-root/mingw/bin/wrjpgcom Is here any reason to have them installed?
yes and no. we usually ship those binaries which needed on win32 eg: openssl.exe the reason for this is that nsis or nsiswrapper can collect all required libs and exes for the installer and then the final installer can contain all component which required on win32. however in this case these exe should have to be called *.exe:-( i send a patch to the mailing list.
Although application programs are excluded from the MinGW project, we do ship the occasional Win32 binary if it would be useful for testing, development or debugging. Examples include: - openssl.exe (so developers and end users can debug certificates) - certtool.exe (for the same reason) - worms.exe (useful demo program which can be used to find out if all the components leading up to the windows console are working) In this case, I don't think any of those binaries are useful for this purpose, so they should be excluded. The following excludes them, and also includes Levente's patch from comment 6. Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/libjpeg/mingw32-libjpeg.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-libjpeg-6b-8.fc11.src.rpm * Wed Jan 28 2009 Richard W.M. Jones <rjones> - 6b-8 - Exclude the binaries. - Rename the binaries to *.exe (Levente Farkas).
Ok, all problems have been fixed => reviewed.
New Package CVS Request ======================= Package Name: mingw32-libjpeg Short Description: MinGW Windows Libjpeg library Owners: rjones berrange lfarkas Branches: F-10 EL-5 InitialCC:
cvs done.
mingw32-libjpeg-6b-8.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.