Bug 1023776

Summary: Review Request: eclus - An Erlang Port Mapping Daemon service
Product: [Fedora] Fedora Reporter: Peter Lemenkov <lemenkov>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, golang-updates, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-10 11:01:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1023769, 1023771, 1023772, 1023773, 1023774    
Bug Blocks:    

Description Peter Lemenkov 2013-10-27 19:11:44 UTC
Spec URL: http://peter.fedorapeople.org/eclus.spec
SRPM URL: http://peter.fedorapeople.org/eclus-0-0.1.20131021gitb13fe6f.fc21.src.rpm
Description: An Erlang Port Mapping Daemon service
Fedora Account System Username: peter

Comment 1 Robert-André Mauchin 🐧 2020-03-09 22:34:51 UTC
 - Please follow Go packaging guidelines for binaries:

# Generated by go2rpm 1
%bcond_without check

# https://github.com/goerlang/eclus
%global goipath         github.com/goerlang/eclus
%global commit          5efcbfc98a5caa9af3e81d4ba8f938efcfdc8802

%gometa

%global common_description %{expand:
Erlang EPMD replacement and example of node.}

%global golicenses      LICENSE
%global godocs          README.md

Name:           %{goname}
Version:        0
Release:        0.1%{?dist}
Summary:        Erlang EPMD replacement and example of node

License:        MIT
URL:            %{gourl}
Source0:        %{gosource}

BuildRequires:  golang(github.com/coreos/go-systemd/activation)
BuildRequires:  golang(github.com/goerlang/epmd)
BuildRequires:  golang(github.com/goerlang/etf)
BuildRequires:  golang(github.com/goerlang/node)
BuildRequires:  systemd-rpm-macros

%description
%{common_description}

%prep
%goprep

%build
for cmd in src/eclus; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done

%install
install -m 0755 -vd                     %{buildroot}%{_bindir}
install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
install -D -p -m 0644 %{name}.service %{buildroot}%{_unitdir}/%{name}.service
install -D -p -m 0644 %{name}.socket %{buildroot}%{_unitdir}/%{name}.socket

%post
%systemd_post %{name}.service

%preun
%systemd_preun %{name}.service

%postun
%systemd_postun %{name}.service

%files
%license LICENSE
%doc README.md
%{_bindir}/*
%{_unitdir}/%{name}.service
%{_unitdir}/%{name}.socket

%changelog

Comment 2 Peter Lemenkov 2020-03-10 11:01:42 UTC
(In reply to Robert-André Mauchin from comment #1)
>  - Please follow Go packaging guidelines for binaries:

Thanks for the tip - I'll take a look. This project was superseded by a different one so instead I'll package a new one.