Bug 1069628

Summary:	It's possible to set nonsense value of RAM size of vm/template.
Product:	[Retired] oVirt	Reporter:	Ondra Machacek <omachace>
Component:	ovirt-engine-core	Assignee:	Martin Betak <mbetak>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.4	CC:	acathrow, gklein, iheim, mbetak, movciari, ofrenkel, yeylon
Target Milestone:	---
Target Release:	3.4.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-08 13:37:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ondra Machacek 2014-02-25 12:27:37 UTC

Description of problem:
When creating/updating vm, it's possible to set nonsense value of RAM of vm.
There is tooltip for setting mimunum ram size of 256MB and it is possible to 
set value < 256M and if it's bigger then some limit(ie 2147483647 GB) then it 
overflows to zero. 

It's also possible to write value like: '12a30 MB'. Which 
is truncated to 12. Would be better to tell there is nonsense value.

Since ovirt supports up to 2TB RAM of vm, would be good to also allow input in
* TB. Which is not working now( TB is considered as MB ).

Version-Release number of selected component (if applicable):
ovirt-engine-3.4.0-0.11.beta3.el6.noarch

How reproducible:
always

Steps to Reproduce:
1. Check description of problem.

Actual results:


Expected results:


Additional info:

Comment 1 Ondra Machacek 2014-02-25 12:49:55 UTC

Please also fix the REST for long values. (see bug 1000796).

Comment 2 Itamar Heim 2014-03-02 05:42:53 UTC

Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.

Comment 3 Sandro Bonazzola 2014-03-04 09:27:48 UTC

This is an automated message.
Re-targeting all non-blocker bugs still open on 3.4.0 to 3.4.1.

Comment 4 Michal Skrivanek 2014-03-09 13:14:08 UTC

*** Bug 1073450 has been marked as a duplicate of this bug. ***

Comment 5 Omer Frenkel 2014-03-09 13:39:03 UTC

please note it was requested in bug 1014952 not to block the user from setting not recommended values (like <256) so there should be a warning in the event log for this.
anyway we do need some sanity, memory should be a number, non negative and shouldn't exceed max int.

Comment 6 Omer Frenkel 2014-03-16 09:11:34 UTC

*** Bug 1076094 has been marked as a duplicate of this bug. ***

Comment 7 Sandro Bonazzola 2014-05-08 13:37:10 UTC

This is an automated message

oVirt 3.4.1 has been released:
 * should fix your issue
 * should be available at your local mirror within two days.

If problems still persist, please make note of it in this bug report.