Bug 1100768

Summary: Review Request: rubygem-fog-core - Shared classes and tests for fog providers and services.
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: Package ReviewAssignee: Josef Stribny <jstribny>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: hhorak, jstribny, package-review, tdawson
Target Milestone: ---Flags: jstribny: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-fog-core-1.22.0-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-28 13:48:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1100461    
Bug Blocks: 973071, 1100776, 1100795    

Description Vít Ondruch 2014-05-23 12:14:07 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-fog-core.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-fog-core-1.22.0-1.fc21.src.rpm
Description: Shared classes and tests for fog providers and services.
Fedora Account System Username: vondruch

Comment 1 Josef Stribny 2014-05-23 12:49:28 UTC
* LICENSE.md, README.md and changelog.md files should be marked as %doc.
* There is some trailing white space in spec you probably want to remove.

Otherwise the package builds, installs, runs. Tests are passing. rpmlint doesn't complain. As the issues are minor and easy to fix => APPROVED. Please fix them before pushing.

Comment 2 Vít Ondruch 2014-05-23 13:12:38 UTC
Thanks for the review. I fixed the issues locally.



New Package SCM Request
=======================
Package Name: rubygem-fog-core
Short Description: Shared classes and tests for fog providers and services
Upstream URL: https://github.com/fog/fog-core
Owners: vondruch
Branches: 
InitialCC:

Comment 3 Gwyn Ciesla 2014-05-27 13:16:04 UTC
Git done (by process-git-requests).

Comment 4 Gwyn Ciesla 2014-05-27 13:23:30 UTC
Git done (by process-git-requests).

Comment 5 Troy Dawson 2014-12-18 23:33:43 UTC
Package Change Request
======================
Package Name: rubygem-fog-core
New Branches: epel7
Owners: tdawson

Comment 6 Gwyn Ciesla 2014-12-19 13:40:54 UTC
Git done (by process-git-requests).