Bug 1111948 (kf5-kio)

Build fails with:

/builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp: In member function 'virtual void KIO::DataProtocol::get(const QUrl&)':
/builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp:280:89: error: no matching function for call to 'QString::toLatin1() const'
         QTextCodec *codec = QTextCodec::codecForName(hdr.attributes["charset"].toLatin1());
                                                                                         ^
/builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp:280:89: note: candidates are:
In file included from /usr/include/qt5/QtCore/QString:1:0,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/global.h:23,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/dataslave_p.h:25,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol_p.h:49,
                 from /builddir/build/BUILD/kio-4.100.0/src/core/dataprotocol.cpp:19:
/usr/include/qt5/QtCore/qstring.h:465:16: note: QByteArray QString::toLatin1() const &
     QByteArray toLatin1() const & Q_REQUIRED_RESULT
                ^
/usr/include/qt5/QtCore/qstring.h:465:16: note:   no known conversion for implicit 'this' parameter from 'const QString' to 'const QString&'
/usr/include/qt5/QtCore/qstring.h:467:16: note: QByteArray QString::toLatin1() &&
     QByteArray toLatin1() && Q_REQUIRED_RESULT
                ^
/usr/include/qt5/QtCore/qstring.h:467:16: note:   no known conversion for implicit 'this' parameter from 'const QString' to 'QString&&'
src/core/CMakeFiles/KF5KIOCore.dir/build.make:725: recipe for target 'src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o' failed
make[2]: *** [src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/builddir/build/BUILD/kio-4.100.0/i686-redhat-linux-gnu'
CMakeFiles/Makefile2:3743: recipe for target 'src/core/CMakeFiles/KF5KIOCore.dir/all' failed
make[1]: *** [src/core/CMakeFiles/KF5KIOCore.dir/all] Error 2
make[1]: Leaving directory '/builddir/build/BUILD/kio-4.100.0/i686-redhat-linux-gnu'
Makefile:120: recipe for target 'all' failed
make: Leaving directory '/builddir/build/BUILD/kio-4.100.0/i686-redhat-linux-gnu'
make: *** [all] Error 2

Builds just fine here and in Copr and the error itself does not make much sense to me. Maybe there's something wrong with your Qt 5 setup or environment?

I hit the same problem when I was building qt5-qtbase in rawhide, it was an issue in gcc and it worked later with a newer build. I'll finish the review since Lukáš is on PTO.

1) License - some files are also under GPLv2+, BSD and MIT licenses.
2) Missing call of update-desktop-database, because of a desktop file with a Mimetype entry.
3) Missing %config before files installed to /etc/xdg

Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kio.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kio-4.100.0-2.fc20.src.rpm

- fixed licenses
- added %%config
- added update-desktop-database

It's not necessary to have Requires: kf5-kwallet-libs, just remove it during import. The rest looks good, approved.

New Package SCM Request
=======================
Package Name: kf5-kio
Short Description: KDE Frameworks 5 Tier 3 solution for filesystem abstraction
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl kkofler rdieter than
Branches: 
InitialCC:

Git done (by process-git-requests).

Package Change Request
=======================
Package Name: kf5-kio
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than

Git done (by process-git-requests).