Bug 1162856
| Summary: | Missing high contrast icon | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Shea <dshea> | ||||
| Component: | fedora-logos | Assignee: | Tom "spot" Callaway <tcallawa> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 21 | CC: | anaconda-maint-list, ccecchi, dshea, extras-qa, g.kaviyarasu, jonathan, jreznik, jsteiner, kparal, mcatanzaro+wrong-account-do-not-cc, mclasen, mruckman, robatino, satellitgo, tcallawa, vanmeeuwen+fedora | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | AcceptedBlocker | ||||||
| Fixed In Version: | fedora-logos-21.0.5-1.fc21 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | 1160499 | Environment: | |||||
| Last Closed: | 2014-11-22 00:46:14 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1043129, 1160499 | ||||||
| Attachments: |
|
||||||
|
Description
David Shea
2014-11-11 21:24:47 UTC
Proposed as a Blocker for 21-final by Fedora user dshea using the blocker tracking app because: This change is required for bug 1160499, which was accepted as a 21-final blocker. (In reply to Fedora Blocker Bugs Application from comment #1) > This change is required for bug 1160499, which was accepted as a 21-final > blocker. If I am not mistaken, proposing this is not strictly necessary, because this bug already blocks bug 1160499, which makes it a blocker transitively. But no harm done even this way. Do the two new hi-contrast icons (fedora logo, and install to HDD icon) need the full set of icon sizes? or does the criteria just state the launcher? Is the 256x256 icon always shown on the launcher? I'm not sure how to answer your questions so here's some more technical details. /usr/share/icons/Fedora/256x256/places/start-here.png (the fedora logo) is used by (and as far as I know, only by) fedora-welcome. fedora-welcome is started via autostart upon logging in as the live user, but the desktop file sets NoDisplay and thus fedora-welcome does not appear in the activities menu. The install to hdd icon currently has, in the anaconda repo, sizes for 16x16, 22x22, 24x24, 32x32, 48x48, and 256x256. If any of these are unneeded, let us know. This icon is referenced by icon name by liveinst.desktop. liveinst does appear in the activities menu. The upstream GNOME requirement for application icons is for 256x256px, 48x48px, 32x32px, 24x24px and 16x16px variants of the icon, with 512x512px recommended but optional, and all other sizes (notably 22x22px and 128x128px) are unnecessary (but harmless). [1] That would be the ideal resolution to this bug. But in contrast, the Fedora Workstation requirement [2] -- which applies to this bug -- is specifically that a 128x128px icon must be present. It mentions no other icon size, but the intent behind the requirement was that 256x256px is a high bar for applications to meet, and that a 128x128px icon would be sufficient if a 256x256px icon is not provided (the wording can be uncontroversially changed if there's concern about not actually including a 128x128px icon). It's not even clear from the wording that the icon size requirement applies to the high contrast icon at all. So... take that as you will. The Fedora criteria is not really very specific. I suspect whatever high contrast icons you provide will be gratefully accepted. In particular, if the non-high contrast start here logo only exists as a 256x256px icon, then there's not much sense in expecting more sizes from the high contrast variant. (In reply to Ryan Lerch from comment #3) > Do the two new hi-contrast icons (fedora logo, and install to HDD icon) need > the full set of icon sizes? or does the criteria just state the launcher? The Fedora criteria specifically applies to the launcher. [1] > Is the 256x256 icon always shown on the launcher? On normal displays, I think so, for both the app grid and the dock (so it will be used even if NoDisplay=false), with a fallback to smaller icon sizes if not present. (I think a 512x512px icon will be used instead on high-DPI displays.) The icon used for the app menu (next to Activities when the app is focused) is 48x48px (on normal displays, again with fallback to other sizes if not present). [1] https://people.gnome.org/~tobiasmue/hig3/icons-and-artwork.html [2] https://fedoraproject.org/wiki/Workstation/Guidelines/Applications_and_Launchers On IRC it was decided that the best way to handle start-here.png (the Fedora logo in the taskbar) is to get rid of it. fedora-welcome is automatically started and not available in the activities menu, so there's not much point in having it in the taskbar. anaconda will set skip-taskbar-hint on the GtkWindow and drop the Icon= from the desktop file. Discussed in 2014-11-19 blocker review meeting. This bug is a clear violation of the Final criterion: All applications installed by default in Fedora Workstation must comply with each MUST and MUST NOT guideline in the Applications and Launchers policy. (In reply to David Shea from comment #6) > On IRC it was decided that the best way to handle start-here.png (the Fedora > logo in the taskbar) is to get rid of it. fedora-welcome is automatically > started and not available in the activities menu, so there's not much point > in having it in the taskbar. anaconda will set skip-taskbar-hint on the > GtkWindow and drop the Icon= from the desktop file. A bit confused on the technical details here: what icon will be displayed for the app menu when fedora-welcome is running? What icon will be displayed for fedora-welcome in the dock, should the user open the overview before closing fedora-welcome? We don't want to wind up with the empty window placeholder icon. (In reply to Michael Catanzaro from comment #8) > (In reply to David Shea from comment #6) > > On IRC it was decided that the best way to handle start-here.png (the Fedora > > logo in the taskbar) is to get rid of it. fedora-welcome is automatically > > started and not available in the activities menu, so there's not much point > > in having it in the taskbar. anaconda will set skip-taskbar-hint on the > > GtkWindow and drop the Icon= from the desktop file. > > A bit confused on the technical details here: what icon will be displayed > for the app menu when fedora-welcome is running? None. It won't have an app menu it is a ghost. https://dshea.fedorapeople.org/fedora-welcome/normal.png > What icon will be displayed > for fedora-welcome in the dock, should the user open the overview before > closing fedora-welcome? oooOOOOOoOoooooooo https://dshea.fedorapeople.org/fedora-welcome/overview.png It's kind of weird (spooky?) that it disappears entirely when you switch to the overview but we live in an imperfect world with an imperfect gnome-shell. fedora-logos-21.0.5-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/fedora-logos-21.0.5-1.fc21 Package fedora-logos-21.0.5-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fedora-logos-21.0.5-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-15444/fedora-logos-21.0.5-1.fc21 then log in and leave karma (feedback). After upgrading fedora-logos on TC2 Live, fedora-welcome no longer starts. I assume anaconda changes are necessary first. fedora-logos-21.0.5-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |
