Bug 1233484

Summary:	Possible double execution of the state machine for fops that start other subfops
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	disperse	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.1	CC:	bugs, gluster-bugs, jahernan
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1233258	Environment:
Last Closed:	2015-06-20 09:51:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1233258
Bug Blocks:	1233025, 1233282

Description Pranith Kumar K 2015-06-19 03:40:14 UTC

+++ This bug was initially created as a clone of Bug #1233258 +++

Description of problem:

When a fop starts a subfop as part of its own execution, it's possible that this subfop finishes before the manager has completed the processing of the current state. In this case ec_resume() is called and a new instance of the same state machine is executed by another thread.

This could cause multiple problems.

Version-Release number of selected component (if applicable): mainline


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-06-18 10:52:24 EDT ---

REVIEW: http://review.gluster.org/11317 (cluster/ec: Avoid parallel executions of the same state machine) posted (#1) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2015-06-18 12:17:32 EDT ---

REVIEW: http://review.gluster.org/11317 (cluster/ec: Avoid parallel executions of the same state machine) posted (#2) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2015-06-18 23:39:07 EDT ---

REVIEW: http://review.gluster.org/11317 (cluster/ec: Avoid parallel executions of the same state machine) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 1 Anand Avati 2015-06-19 03:43:51 UTC

REVIEW: http://review.gluster.org/11319 (cluster/ec: Avoid parallel executions of the same state machine) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2015-06-19 06:35:18 UTC

COMMIT: http://review.gluster.org/11319 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit c4d4d2247b3aeb96e37a05aeb0f73cec54360094
Author: Xavier Hernandez <xhernandez>
Date:   Thu Jun 18 16:44:55 2015 +0200

    cluster/ec: Avoid parallel executions of the same state machine
    
            Backport of http://review.gluster.org/11317
    
    In very rare circumstances it was possible that a subfop started
    by another fop could finish fast enough to cause that two or more
    instances of the same state machine be executing at the same time.
    
    Change-Id: I319924a18bd3f88115e751a66f8f4560435e0e0e
    BUG: 1233484
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/11319
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Niels de Vos 2015-06-20 09:51:47 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Xavi Hernandez 2015-06-30 13:25:59 UTC

*** Bug 1233282 has been marked as a duplicate of this bug. ***