Bug 1242269
| Summary: | protocol server : Pending - porting log messages to a new framework | |||
|---|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | SATHEESARAN <sasundar> | |
| Component: | core | Assignee: | Raghavendra G <rgowdapp> | |
| Status: | CLOSED WONTFIX | QA Contact: | Anoop <annair> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | rhgs-3.1 | CC: | nbalacha, rhs-bugs, smohan | |
| Target Milestone: | --- | Keywords: | ZStream | |
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1252808 (view as bug list) | Environment: | ||
| Last Closed: | 2018-02-06 06:13:59 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1252808, 1257193 | |||
Description of problem: ----------------------- There are few instances of gf_log and gf_log_callingfn seen under protocol server component under the code base. These needs to be ported in to new logging framework Version-Release number of selected component (if applicable): -------------------------------------------------------------- RHGS 3.1 Nightly build ( glusterfs-3.7.1-8.el6rhs ) Additional info: ---------------- Here are the instances of gf_log : [satheesaran@dhcppc1 server]$ grep -r "gf_log " * -A1 src/server-rpc-fops.c: gf_log (this->name, GF_LOG_INFO, src/server-rpc-fops.c- "%"PRId64": IPC%"PRId64" (%s) ==> (%s)", -- src/server.c: gf_log (this->name, GF_LOG_WARNING, src/server.c- "Received invalid upcall event(%d)", -- src/server.c: gf_log (this->name, GF_LOG_ERROR, src/server.c- "server_process_event_upcall failed"); Here are the instances of gf_log_callingfn: [satheesaran@dhcppc1 server]$ grep -r "gf_log_callingfn " * -A1 src/server.c: gf_log_callingfn (THIS->name, GF_LOG_ERROR, src/server.c- "Failed to get iobuf"); -- src/server.c: gf_log_callingfn ("", GF_LOG_ERROR, "Failed to encode message"); src/server.c- req->rpc_err = GARBAGE_ARGS; -- src/server.c: gf_log_callingfn ("", GF_LOG_ERROR, "Reply submission failed"); src/server.c- if (frame && client && !lk_heal) { -- src/server.c: gf_log_callingfn ("", GF_LOG_ERROR, src/server.c- "Reply submission failed"); -- src/server.c: gf_log_callingfn ("server", GF_LOG_WARNING, src/server.c- "Calling rpc_notify without initializing"); -- src/server.c: gf_log_callingfn (this->name, GF_LOG_DEBUG, "conf == null!!!"); src/server.c- goto out;