Bug 1252808 - protocol server : Pending - porting log messages to a new framework
Summary: protocol server : Pending - porting log messages to a new framework
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: logging
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Manikandan
QA Contact:
URL:
Whiteboard:
Depends On: 1242269
Blocks: 1241957 1257193
TreeView+ depends on / blocked
 
Reported: 2015-08-12 09:28 UTC by Manikandan
Modified: 2016-09-20 04:29 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1242269
: 1257193 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:30:53 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Manikandan 2015-08-12 09:28:50 UTC
+++ This bug was initially created as a clone of Bug #1242269 +++

Description of problem:
-----------------------
There are few instances of gf_log and gf_log_callingfn seen under protocol server component under the code base.
These needs to be ported in to new logging framework

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
RHGS 3.1 Nightly build ( glusterfs-3.7.1-8.el6rhs )


Additional info:
----------------
Here are the instances of gf_log :
[satheesaran@dhcppc1 server]$ grep -r "gf_log " * -A1
src/server-rpc-fops.c:  gf_log (this->name, GF_LOG_INFO,
src/server-rpc-fops.c-         "%"PRId64": IPC%"PRId64" (%s) ==> (%s)",
--
src/server.c:  gf_log (this->name, GF_LOG_WARNING,
src/server.c-       "Received invalid upcall event(%d)",
--
src/server.c:  gf_log (this->name, GF_LOG_ERROR,
src/server.c-       "server_process_event_upcall failed");

Here are the instances of gf_log_callingfn:
[satheesaran@dhcppc1 server]$ grep -r "gf_log_callingfn " * -A1
src/server.c:                        gf_log_callingfn (THIS->name, GF_LOG_ERROR,
src/server.c-                                          "Failed to get iobuf");
--
src/server.c:                        gf_log_callingfn ("", GF_LOG_ERROR, "Failed to encode message");
src/server.c-                        req->rpc_err = GARBAGE_ARGS;
--
src/server.c:                gf_log_callingfn ("", GF_LOG_ERROR, "Reply submission failed");
src/server.c-                if (frame && client && !lk_heal) {
--
src/server.c:                        gf_log_callingfn ("", GF_LOG_ERROR,
src/server.c-                                          "Reply submission failed");
--
src/server.c:                gf_log_callingfn ("server", GF_LOG_WARNING,
src/server.c-                                  "Calling rpc_notify without initializing");
--
src/server.c:                gf_log_callingfn (this->name, GF_LOG_DEBUG, "conf == null!!!");
src/server.c-                goto out;

Comment 1 Anand Avati 2015-08-13 11:02:38 UTC
REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing gf_log's to gf_msg) posted (#3) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 2 Anand Avati 2015-08-17 11:07:32 UTC
REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing gf_log's to gf_msg) posted (#4) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 3 Anand Avati 2015-08-20 07:01:36 UTC
REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing gf_log's to gf_msg) posted (#6) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 4 Anand Avati 2015-08-24 07:29:45 UTC
REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing gf_log's to gf_msg) posted (#7) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 5 Anand Avati 2015-08-26 11:11:13 UTC
REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing gf_log's to gf_msg) posted (#8) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 6 Anand Avati 2015-08-26 12:08:27 UTC
COMMIT: http://review.gluster.org/11895 committed in master by Raghavendra G (rgowdapp) 
------
commit a26dbb38acdb2ec5fe16068caee189709faae76e
Author: Manikandan Selvaganesh <mselvaga>
Date:   Wed Aug 12 15:29:31 2015 +0530

    protocol/server : porting missing gf_log's to gf_msg
    
    Change-Id: I8818931fafea3c013551a5de23a9f77c81164841
    BUG: 1252808
    Signed-off-by: Manikandan Selvaganesh <mselvaga>
    Reviewed-on: http://review.gluster.org/11895
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 14:43:06 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 8 Niels de Vos 2016-06-16 13:30:53 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.