Bug 1242269 - protocol server : Pending - porting log messages to a new framework
Summary: protocol server : Pending - porting log messages to a new framework
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: core
Version: rhgs-3.1
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
: ---
Assignee: Raghavendra G
QA Contact: Anoop
URL:
Whiteboard:
Depends On:
Blocks: 1252808 1257193
TreeView+ depends on / blocked
 
Reported: 2015-07-12 17:45 UTC by SATHEESARAN
Modified: 2018-02-06 06:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1252808 (view as bug list)
Environment:
Last Closed: 2018-02-06 06:13:59 UTC
Embargoed:


Attachments (Terms of Use)

Description SATHEESARAN 2015-07-12 17:45:32 UTC
Description of problem:
-----------------------
There are few instances of gf_log and gf_log_callingfn seen under protocol server component under the code base.
These needs to be ported in to new logging framework

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
RHGS 3.1 Nightly build ( glusterfs-3.7.1-8.el6rhs )


Additional info:
----------------
Here are the instances of gf_log :
[satheesaran@dhcppc1 server]$ grep -r "gf_log " * -A1
src/server-rpc-fops.c:  gf_log (this->name, GF_LOG_INFO,
src/server-rpc-fops.c-         "%"PRId64": IPC%"PRId64" (%s) ==> (%s)",
--
src/server.c:  gf_log (this->name, GF_LOG_WARNING,
src/server.c-       "Received invalid upcall event(%d)",
--
src/server.c:  gf_log (this->name, GF_LOG_ERROR,
src/server.c-       "server_process_event_upcall failed");

Here are the instances of gf_log_callingfn:
[satheesaran@dhcppc1 server]$ grep -r "gf_log_callingfn " * -A1
src/server.c:                        gf_log_callingfn (THIS->name, GF_LOG_ERROR,
src/server.c-                                          "Failed to get iobuf");
--
src/server.c:                        gf_log_callingfn ("", GF_LOG_ERROR, "Failed to encode message");
src/server.c-                        req->rpc_err = GARBAGE_ARGS;
--
src/server.c:                gf_log_callingfn ("", GF_LOG_ERROR, "Reply submission failed");
src/server.c-                if (frame && client && !lk_heal) {
--
src/server.c:                        gf_log_callingfn ("", GF_LOG_ERROR,
src/server.c-                                          "Reply submission failed");
--
src/server.c:                gf_log_callingfn ("server", GF_LOG_WARNING,
src/server.c-                                  "Calling rpc_notify without initializing");
--
src/server.c:                gf_log_callingfn (this->name, GF_LOG_DEBUG, "conf == null!!!");
src/server.c-                goto out;


Note You need to log in before you can comment on or make changes to this bug.