Bug 1278733
| Summary: | Pods Terminal tab should support copy/paste text | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Libor Fuka <lfuka> | ||||||
| Component: | Management Console | Assignee: | Jessica Forrester <jforrest> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Yadan Pei <yapei> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 3.1.0 | CC: | aos-bugs, cpatters, dmcphers, hasha, jforrest, jokerman, mmccomas, nbhatt, rhamilto, spadgett, stefw, xxia, yanpzhan, yapei | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | 3.10.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: |
Copy and paste in the web console container terminal did not work properly on Firefox and Internet Explorer. This has been fixed. You can now copy and fix from the context menu or using keyboard shortcuts.
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-07-30 19:08:59 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Libor Fuka
2015-11-06 10:18:06 UTC
Using the right click menu works in Chrome/Safari. Will need to investigate why right click menu doesn't work on firefox and IE. term.js has different keyboard shortcuts for copy/paste because of selection modes, see https://github.com/chjj/term.js/#tmux-like We probably need to add a help tooltip somewhere about the keyboard shortcut thing because that's unexpected behavior. Stef why are we locking to term.js 0.0.3? 0.0.3 was tested with Cockpit. But we can try out later versions and bump the version. I would suggest that we try and contribute Ctrl-Shift-C and Ctrl-Shift-V upstream as keyboard shortcuts, if we can make them work. Took a quick look and apparently the bower version of term.js is a fork of the actual term.js repo and is missing the latest several versions. I opened an issue to the main repo to see if they are willing to resolve it and take over maintenance. https://github.com/chjj/term.js/issues/103 *** Bug 1339516 has been marked as a duplicate of this bug. *** (In reply to shahan from comment #9) > This bug has been fixed in the https://trello.com/c/zoxUAO2w, Tested this on > all related browers, could copy/paste text in the pod terminal. > OpenShift Master:v3.6.0-rc.0+01e5a1b-550 > QE could verify when it's changed to ON_QA. Please ignore this. See below (In reply to Jessica Forrester from comment #1) > Using the right click menu works in Chrome/Safari. Will need to investigate > why right click menu doesn't work on firefox and IE. In my check on v3.7.0-0.126.4, I checked right click menu in terminal on FF (latest 55.0.3), IE (version 11.608.15063.0), Edge, Chrome. IE now can show Copy/Paste on right click menu in terminal and Copy/Paste work. But FF still has problem. And FF copy/paste behavior differs on Fedora and Windows 10: On Windows 10 FF, the terminal right click does not show Copy/Paste at all On Fedora FF: when terminal text is not selected, it can show Copy/Paste, the Paste works, but the Copy is also shown, which should be gray disabled or not shown. when terminal text is selected, it cannot show Copy, which should be shown. See screenshots Created attachment 1328362 [details]
FF_on_Fedora_terminal_copy_paste_issue
Created attachment 1328363 [details]
FF_on_Windows10_terminal_copy_paste_issue
(In reply to Xingxing Xia from comment #10) > See screenshots Typo. Should be video records Opened upstream xterm.js issue: https://github.com/sourcelair/xterm.js/issues/1003 *** Bug 1477132 has been marked as a duplicate of this bug. *** This also affects the debug terminal since its the same xterm.js component being used. Seems this fix PR still not merge. https://github.com/openshift/origin-web-console/issues/2531. Samuel, could you help set the right target release? PR to resolve: https://github.com/openshift/origin-web-console/pull/2860 It bumps xterm.js to v3.1.0 Could we change to ON_QA now? QE could verify on time when it's changed to ON_QA. @all move this to verify since it has been fixed for a long time and will accept related trello card. Thx. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1816 |