Bug 1280485 (python-PyMVPA)
| Summary: | Review Request: python-PyMVPA - Multivariate pattern analysis | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | besser82, igor.raits, package-review, sanjay.ankur, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-08-22 07:31:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1265670, 1276871, 1278685 | ||
| Bug Blocks: | 201449, 1276941 | ||
|
Description
Igor Gnatenko
2015-11-11 20:45:12 UTC
besser82's shogun-4.0.1-0.4.git20150913.d8eb73d.fc24 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=704166 * * * FYI Can you do review because shogun fixed and other packages in place? ;) Yes, I'll probably do a round of review work this weekend. - name should be lowercase
- xvfb-run should be used with "-a" (automatically select free display number)
- #!/usr/bin/env /usr/bin/pythonX should be replaced with #!/usr/bin/pythonX
Now the usual question: are executables for both python versions wanted?
* pymvpa2 has support for loading python code with --preload, so yes
* pymvpa2-prep-afni-surf just calls a function to preprocess some data, so no
* pymvpa2-prep-fmri likewise no
* pymvpa2-tutorial starts an IPython interactive session, so yes
- so please package just one version for the two executables which don't need two
- Recommends is used for various python modules which are imported. This doesn't seem right, the should be Require-d, since those executables simply don't work without them.
Maybe pymvpa2-tutorial should be split out in a separate subpackage with Requires: python3-ipython.
It would be great to get the tests to pass, that's pretty much the best way to test code compatibility.
Build fails here with:
File not found: /builddir/build/BUILDROOT/python-PyMVPA-2.4.0-3.fc24.x86_64/usr/lib64/python2.7/site-packages/pymvpa2*-egginfo
? Unfortunately I don't have time to work on these review requests anymore, sorry. |