Bug 1287121

Summary: Review Request: perl-Mason-Tidy - Tidy HTML::Mason/Mason components
Product: [Fedora] Fedora Reporter: Jitka Plesnikova <jplesnik>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, psabata
Target Milestone: ---Flags: psabata: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Mason-Tidy-2.57-2.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-11 11:22:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1287080    
Bug Blocks: 1288541    

Description Jitka Plesnikova 2015-12-01 14:40:19 UTC 
Spec URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy-2.57-1.fc24.src.rpm

Description:
Mason::Tidy is the engine used by masontidy. You can call this API from
your own program instead of executing masontidy.

masontidy tidies Mason 1 and Mason 2 components, using perltidy to format
the Perl code that can be embedded in various places in the component.
masontidy does not (yet) attempt to tidy the HTML or other non-Perl content
in a component.

Fedora Account System Username: jplesnik
Comment 1 Upstream Release Monitoring 2015-12-08 08:02:14 UTC 
jplesnik's scratch build of perl-Mason-Tidy-2.57-1.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12108654
Comment 2 Petr Šabata 2015-12-08 16:33:34 UTC 
* Hmm, the test classes, unfortunatelly packaged in the Mason::Tidy::t
  namespace could be subpackaged.  Or excluded completely.  The module
  doesn't use them, neither does the script.

* If you decide to exclude the test classes, you can drop the explicit
  runtime dependencies.

* Add version constraints for Method::Signatures::Simple and Moo.
  For both buildtime and runtime deps.

* The %license compatibility hack isn't really needed as this won't work
  in EPEL anyway (too old EU::MM).
Comment 3 Jitka Plesnikova 2015-12-09 15:10:25 UTC 
I excluded the test modules. Updated files are here:

Spec URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy-2.57-2.fc24.src.rpm
Comment 4 Petr Šabata 2015-12-09 15:44:46 UTC 
Okay, better.

Approving.
Comment 5 Gwyn Ciesla 2015-12-10 15:26:20 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Mason-Tidy
Comment 6 Jitka Plesnikova 2015-12-11 11:22:57 UTC 
Thank you for the review and the repository.