Bug 1290604

Summary: S30Samba scripts do not work on systemd systems
Product: [Community] GlusterFS Reporter: Michael Adam <madam>
Component: gluster-smbAssignee: Michael Adam <madam>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: mainlineCC: bugs, rjoseph
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1292755 (view as bug list) Environment:
Last Closed: 2016-06-16 13:50:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1292755, 1292762, 1292773    

Description Michael Adam 2015-12-10 23:41:28 UTC
Description of problem:

S30Samba hook scripts use /etc/init.d/smb .
But /etc/init.d/smb does not exist on systemd systems.
Using "service smb <COMMAND>" is the portable way.
It calls init scripts on sysv systems, and redirects
to systemctl on systemd systems.


Actual results:

scripts do not (re)start samba

Expected results:

scripts (re)start samba

Comment 1 Vijay Bellur 2015-12-10 23:42:24 UTC
REVIEW: http://review.gluster.org/12945 (hook-scripts: fix S30Samba scripts on systemd systems) posted (#1) for review on master by Michael Adam (obnox)

Comment 2 Vijay Bellur 2015-12-17 12:11:40 UTC
COMMIT: http://review.gluster.org/12945 committed in master by Niels de Vos (ndevos) 
------
commit ce3ff7e328483dffdae6ae2914924bc2380db67e
Author: Michael Adam <obnox>
Date:   Fri Dec 11 00:37:13 2015 +0100

    hook-scripts: fix S30Samba scripts on systemd systems
    
    /etc/init.d/smb does not exist on systemd systems.
    Using "service smb <COMMAND>" is the portable way.
    It calls init scripts on sysv systems, and redirects
    to systemctl on systemd systems.
    
    Change-Id: I7146c9998a51d8b170d3321f3477e92704ae7615
    BUG: 1290604
    Signed-off-by: Michael Adam <obnox>
    Reviewed-on: http://review.gluster.org/12945
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anoop C S <anoopcs>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-06-16 13:50:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user