Bug 1292762

Summary:	(RHEL7) S30Samba scripts do not work on systemd systems
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Michael Adam <madam>
Component:	samba	Assignee:	Michael Adam <madam>
Status:	CLOSED ERRATA	QA Contact:	Vivek Das <vdas>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rhgs-3.1	CC:	nlevinki, rcyriac, rhs-bugs, rjoseph, rtalur, sbhaloth
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	RHGS 3.1.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.5-13	Doc Type:	Bug Fix
Doc Text:	Cause: The Samba hook scripts were explicitly calling SysV-init scripts for Samba /etc/init.d/smb . Consequence: The scripts do not work as expected on systemd systems. The fail to restart or reload Samba when required. Fix: The scripts now use the service command which works both on SysV and systemd systems. Result: The scripts work as expected on SysV and systemd systems.	Story Points:	---
Clone Of:	1292755
Clones:	1292773 (view as bug list)		Environment:
Last Closed:	2016-03-01 06:14:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1290604, 1292755
Bug Blocks:	1292773

Description Michael Adam 2015-12-18 09:58:31 UTC

+++ This bug was initially created as a clone of Bug #1292755 +++

+++ This bug was initially created as a clone of Bug #1290604 +++

Description of problem:

S30Samba hook scripts use /etc/init.d/smb .
But /etc/init.d/smb does not exist on systemd systems.
Using "service smb <COMMAND>" is the portable way.
It calls init scripts on sysv systems, and redirects
to systemctl on systemd systems.


Actual results:

scripts do not (re)start samba

Expected results:

scripts (re)start samba

--- Additional comment from Vijay Bellur on 2015-12-10 18:42:24 EST ---

REVIEW: http://review.gluster.org/12945 (hook-scripts: fix S30Samba scripts on systemd systems) posted (#1) for review on master by Michael Adam (obnox)

--- Additional comment from Vijay Bellur on 2015-12-17 07:11:40 EST ---

COMMIT: http://review.gluster.org/12945 committed in master by Niels de Vos (ndevos) 
------
commit ce3ff7e328483dffdae6ae2914924bc2380db67e
Author: Michael Adam <obnox>
Date:   Fri Dec 11 00:37:13 2015 +0100

    hook-scripts: fix S30Samba scripts on systemd systems
    
    /etc/init.d/smb does not exist on systemd systems.
    Using "service smb <COMMAND>" is the portable way.
    It calls init scripts on sysv systems, and redirects
    to systemctl on systemd systems.
    
    Change-Id: I7146c9998a51d8b170d3321f3477e92704ae7615
    BUG: 1290604
    Signed-off-by: Michael Adam <obnox>
    Reviewed-on: http://review.gluster.org/12945
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anoop C S <anoopcs>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

--- Additional comment from Vijay Bellur on 2015-12-18 04:51:07 EST ---

REVIEW: http://review.gluster.org/13000 (hook-scripts: fix S30Samba scripts on systemd systems) posted (#1) for review on release-3.7 by Michael Adam (obnox)

Comment 3 rjoseph 2015-12-19 05:22:54 UTC

Upstream Master: http://review.gluster.org/12945 
Upstream Release 3.7: http://review.gluster.org/13000
Downstream : https://code.engineering.redhat.com/gerrit/#/c/64209/

Comment 5 surabhi 2015-12-29 11:13:50 UTC

Please add fixed in Version.

Comment 6 Vivek Das 2015-12-30 11:22:33 UTC

Ran this test and verified hook-scripts fix S30Samba scripts on systemd systems.
Did a service smb condrestart and it does start the smb service successfully.

Versions:
glusterfs-cli-3.7.5-13.el7rhgs.x86_64
samba-client-4.2.4-12.el7rhgs.x86_64

Comment 8 errata-xmlrpc 2016-03-01 06:14:10 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0192.html