Bug 1293601

Summary: quota: handle quota xattr removal when quota is enabled again
Product: [Community] GlusterFS Reporter: Vijaikumar Mallikarjuna <vmallika>
Component: quotaAssignee: Manikandan <mselvaga>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, rgowdapp, smohan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1294609 1294642 (view as bug list) Environment:
Last Closed: 2016-06-16 13:51:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1294609, 1294642    

Description Vijaikumar Mallikarjuna 2015-12-22 10:59:28 UTC
When a quota is disable and enabled again before completing
the cleanup operation, this can remove the new xattrs
and quota accounting can become wrong

Remove removing the xattr, check if quota enabled again and the
xattr is new

Comment 1 Vijay Bellur 2015-12-22 11:07:42 UTC
REVIEW: http://review.gluster.org/13065 (quota: handle quota xattr removal when quota is enabled again) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Vijay Bellur 2015-12-22 11:09:48 UTC
REVIEW: http://review.gluster.org/13065 (quota: handle quota xattr removal when quota is enabled again) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 3 Vijay Bellur 2015-12-28 12:17:28 UTC
REVIEW: http://review.gluster.org/13065 (quota: handle quota xattr removal when quota is enabled again) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 4 Vijay Bellur 2016-01-06 11:55:04 UTC
REVIEW: http://review.gluster.org/13065 (quota: handle quota xattr removal when quota is enabled again) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 5 Vijay Bellur 2016-01-07 08:20:15 UTC
REVIEW: http://review.gluster.org/13065 (quota: handle quota xattr removal when quota is enabled again) posted (#5) for review on master by Raghavendra G (rgowdapp)

Comment 6 Vijay Bellur 2016-01-07 08:20:31 UTC
COMMIT: http://review.gluster.org/13065 committed in master by Raghavendra G (rgowdapp) 
------
commit 33ca7a7384491bf78f1c905a9085c17415eb1d91
Author: vmallika <vmallika>
Date:   Tue Dec 22 16:32:49 2015 +0530

    quota: handle quota xattr removal when quota is enabled again
    
    When a quota is disable and enabled again before completing
    the cleanup operation, this can remove the new xattrs
    and quota accounting can become wrong
    
    Remove removing the xattr, check if quota enabled again and the
    xattr is new
    
    Change-Id: Idda216f1e7346a9b843dbc112ea3e6faa9c47483
    BUG: 1293601
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/13065
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>

Comment 9 Niels de Vos 2016-06-16 13:51:54 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user