Bug 1315377
| Summary: | A copy of custom alert replace your custom alert | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | kpichard | |
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | |
| Status: | CLOSED ERRATA | QA Contact: | Dmitry Misharov <dmisharo> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 5.5.0 | CC: | carnott, dmisharo, hkataria, jhardy, jprause, mfeifer, mpovolny, nachandr, obarenbo | |
| Target Milestone: | GA | Keywords: | ZStream | |
| Target Release: | 5.6.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | alert | |||
| Fixed In Version: | 5.6.0.0 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1316137 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-29 15:40:29 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1316137 | |||
|
Description
kpichard
2016-03-07 15:25:10 UTC
*** Bug 1315450 has been marked as a duplicate of this bug. *** New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/9ce911e887f7eb08fdee6a463b0e9f36d50e332b commit 9ce911e887f7eb08fdee6a463b0e9f36d50e332b Author: Harpreet Kataria <hkataria> AuthorDate: Tue Mar 8 11:10:48 2016 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Mar 8 15:50:30 2016 -0500 When copying an alert record dont copy id of the record. Presence of id in @alert was causing UI to think that existing record is being edited instead a new copied record being added. Due to this incorrect cell title and form buttons were displayed on screen. https://bugzilla.redhat.com/show_bug.cgi?id=1315377 app/controllers/miq_policy_controller/alerts.rb | 4 +-- .../miq_policy_controller/alerts_spec.rb | 29 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) create mode 100644 spec/controllers/miq_policy_controller/alerts_spec.rb New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b862553d5c36e67551f0945031e0543fbc6e66e8 commit b862553d5c36e67551f0945031e0543fbc6e66e8 Author: Harpreet Kataria <hkataria> AuthorDate: Tue Mar 8 11:10:48 2016 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Fri Mar 11 09:13:17 2016 -0500 When copying an alert record dont copy id of the record. Presence of id in @alert was causing UI to think that existing record is being edited instead a new copied record being added. Due to this incorrect cell title and form buttons were displayed on screen. https://bugzilla.redhat.com/show_bug.cgi?id=1315377 https://bugzilla.redhat.com/show_bug.cgi?id=1316137 (cherry picked from commit 9ce911e) app/controllers/miq_policy_controller/alerts.rb | 4 +-- .../miq_policy_controller/alerts_spec.rb | 29 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) create mode 100644 spec/controllers/miq_policy_controller/alerts_spec.rb New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=93869904e2e13e9014bf545d98b6543faf9fcb1a commit 93869904e2e13e9014bf545d98b6543faf9fcb1a Merge: 564108e b862553 Author: Dan Clarizio <dclarizi> AuthorDate: Fri Mar 11 09:52:47 2016 -0500 Commit: Dan Clarizio <dclarizi> CommitDate: Fri Mar 11 09:52:47 2016 -0500 Merge branch '55z_pr_7158' into '5.5.z' When copying an alert record dont copy id of the record. Presence of id in @alert was causing UI to think that existing record is being edited instead a new copied record being added. Due to this incorrect cell title and form buttons were displayed on screen. https://bugzilla.redhat.com/show_bug.cgi?id=1315377 https://bugzilla.redhat.com/show_bug.cgi?id=1316137 (cherry picked from commit 9ce911e) @dclarizi please review/merge, this is clean cherry-pick for https://github.com/ManageIQ/manageiq/pull/7158 See merge request !844 app/controllers/miq_policy_controller/alerts.rb | 4 +-- .../miq_policy_controller/alerts_spec.rb | 29 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) *** Bug 1303645 has been marked as a duplicate of this bug. *** Tested and verified in 5.6.0.0-beta1.20160322143549_f7ea680. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 |