Bug 1326151
Summary: | Review Request: xfce4-calculator-plugin - A calculator plugin for the Xfce4 panel | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mukundan Ragavan <nonamedotc> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, rdieter |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-04-18 17:25:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mukundan Ragavan
2016-04-12 01:13:19 UTC
Some points about review - 1/ When running fedora-review, this will give an error about .desktop file which is bogus. .desktop file is installed under %{_datadir}/xfce4/panel-plugins 2/ fedora-review will also complain about FSF address on the license file. I have already reported it upstream. https://bugzilla.xfce.org/show_bug.cgi?id=12543 3/ The package also uses old autotools macros. I am yet to contact upstream about it. The package works without issues though. It also uses old xfce "conventions". 4/ koji scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=13628690 I can review (probably tomorrow). If you're able/willing to swap, would be swell to get bug #1325469 done Thanks Rex, Taken #1325469 $ rpmlint *.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok sources: ok 8d7bf07a669a2884a409a7b03f89be5c xfce4-calculator-plugin-0.5.1.tar.bz2 licensing: GPLv2 (current) is mostly OK, but all the source code headers also include: ... either version 2 of the License, or * (at your option) any later version. 1. SHOULD update license to License: GPLv2+ macros: ok scriptlets: ok (icons) 2. SHOULD review if this is needed BuildRequires: xorg-x11-server-devel (as far as I can tell, it is not) dir/file ownership: ok APPROVED. Consider reviewing the 2 non-blocker SHOULD items. You are right. xorg-x11-server-devel is indeed not needed. I will fix both items before import. Thanks for the review. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xfce4-calculator-plugin xfce4-calculator-plugin-0.5.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-22503799c6 xfce4-calculator-plugin-0.5.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2bd13f1360 xfce4-calculator-plugin-0.5.1-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-585d44b9db xfce4-calculator-plugin-0.5.1-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfd6df5ec xfce4-calculator-plugin-0.5.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-585d44b9db xfce4-calculator-plugin-0.5.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2bd13f1360 xfce4-calculator-plugin-0.5.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfd6df5ec xfce4-calculator-plugin-0.5.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-22503799c6 xfce4-calculator-plugin-0.5.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. xfwm4-themes-4.10.0-7.el7 xfce4-settings-4.12.0-7.el7 xfce4-xkb-plugin-0.7.1-4.el7 xfce4-smartbookmark-plugin-0.4.6-4.el7 xfce4-datetime-plugin-0.6.2-6.el7 xfce4-equake-plugin-1.3.8-1.el7 xfce4-fsguard-plugin-1.0.2-4.el7 xfce4-hamster-plugin-1.6.1-2.el7 xfce-polkit-0.2-5.el7 xfce4-wavelan-plugin-0.5.12-4.el7 xfce4-cpufreq-plugin-1.1.2-2.el7 xfce4-whiskermenu-plugin-1.5.3-1.el7 xfce4-battery-plugin-1.0.5-11.el7 xfdashboard-0.5.92-3.el7 xfce4-pulseaudio-plugin-0.2.4-4.el7 xfce4-diskperf-plugin-2.5.5-4.el7 xfce4-weather-plugin-0.8.6-3.el7 xfce4-eyes-plugin-4.4.4-3.el7 xfce4-netload-plugin-1.2.4-3.el7 xfce4-sensors-plugin-1.2.5-3.el7 xfce4-genmon-plugin-3.4.0-8.el7 xfce4-mount-plugin-0.6.7-5.el7 xfce4-systemload-plugin-1.1.2-3.el7 xfce4-time-out-plugin-1.0.1-9.el7 thunar-archive-plugin-0.3.1-6.el7 xfce4-cpugraph-plugin-1.0.5-8.el7 xfce4-verve-plugin-1.0.1-4.el7 xfce4-mailwatch-plugin-1.2.0-8.el7 xfce4-screenshooter-1.8.2-5.el7 xfce4-clipman-plugin-1.2.6-5.el7 thunar-volman-0.8.1-2.el7 ristretto-0.8.0-3.el7 parole-0.8.1-2.el7 xfce4-dict-0.7.1-3.el7 xfce4-calculator-plugin-0.5.1-3.el7 xfdesktop-4.12.3-2.el7 xfce4-power-manager-1.6.0-2.el7 xfce4-terminal-0.6.3-4.el7 orage-4.12.1-3.el7 xfce4-session-4.12.1-8.el7 Thunar-1.6.10-4.el7 xfce4-panel-4.12.0-4.el7 xfce4-appfinder-4.12.0-4.el7 xfce4-dev-tools-4.12.0-2.el7 xfce4-notifyd-0.2.4-8.el7 xfwm4-4.12.3-2.el7 garcon-0.4.0-3.el7 exo-0.10.7-1.el7 tumbler-0.1.31-2.el7 libxfce4ui-4.12.1-3.el7 xfconf-4.12.0-3.el7 libxfce4util-4.12.1-2.el7 gtk-xfce-engine-3.2.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-262a3f39e1 xfce4-calculator-plugin-0.5.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |