Bug 1336168
| Summary: | Review Request: git-lfs - Git extension for versioning large files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | clime |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bruno.thomsen, clime, fedora, james.hogarth, jchaloup, package-review, quantum.analyst, sam.bristow, sspreitz, tadej.j, thofmann, wtogami |
| Target Milestone: | --- | Flags: | sspreitz:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-31 22:07:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1336159, 1336161, 1336164, 1486510, 1486511 | ||
| Bug Blocks: | |||
|
Description
Igor Gnatenko
2016-05-15 02:33:56 UTC
Hi Igor I will be reviewing your request. Kind regards Sascha (In reply to Sascha Spreitzer from comment #1) > Hi Igor > > I will be reviewing your request. It's good, what about other packages? ;) > > Kind regards > Sascha Summary:
- please provide %{commit}, %{shortcommit}, %{provider} and the usual macros for Go packages. They are handful (and needed) for tooling running over Go projects packaged in Fedora.
- as long as the package is for Fedora only, BuildRequires: compiler(go-compiler) is fine. It will not work for epel6, epel7 and RHEL7 as compiler(go-compiler) is not defined there.
- provide devel and unit-test subpackages as well (for analysis carried over Go projects in distribution)
- to build from de-bundled dependencies, all imports prefixed with "github.com/github/git-lfs/vendor/_nuts/" must be updated. (Remove the prefix). U can use: sed -i "s/github\.com\/github\/git-lfs\/vendor\/_nuts\///" $(find . -name '*.go')
After removing the vendor prefix, the following list of deps remains:
BuildRequires: golang(github.com/ThomsonReutersEikon/go-ntlm/ntlm)
BuildRequires: golang(github.com/bgentry/go-netrc/netrc)
BuildRequires: golang(github.com/cheggaaa/pb)
BuildRequires: golang(github.com/kr/pty)
BuildRequires: golang(github.com/olekukonko/ts)
BuildRequires: golang(github.com/rubyist/tracerx)
BuildRequires: golang(github.com/spf13/cobra)
I've tried to update this to 1.5.5 [1,2]. Bug 1336166 can be dropped because it's no longer a dependency. It will newly require golang-github-xeipuuv-gojsonschema [3], golang-github-xeipuuv-gojsonpointer [4], and golang-github-xeipuuv-gojsonreference [5]. Since those last three are still in testing, my copr build will probably fail, but the queue is a bit weird today. [1] https://gitlab.com/QuLogic/rpmbuild-specs/commit/9ca0fd8b1ed92c993e053641dfdcc56d38f8f755 [2] https://copr.fedorainfracloud.org/coprs/qulogic/git-lfs/build/511065/ [3] https://bugzilla.redhat.com/show_bug.cgi?id=1405074 [4] https://bugzilla.redhat.com/show_bug.cgi?id=1405067 [5] https://bugzilla.redhat.com/show_bug.cgi?id=1405072 Igor are you still planning on packaging this? Any update on this? git-lfs is v2.0.2 upstream. git-lfs v2.0.1 is available in my copr I linked above. 2.0.2 currently fails to build on F25 as it appears to use a function from Go 1.8. Hi I am sorry i have to step down on this package review, due to lack of time. Kind regards Sascha 2.0.2 spec with patch to build on Go 1.7 is here: https://gitlab.com/qulogic-rpms/git-lfs/tree/master/git-lfs Are you going to continue with this request, Igor? Sorry, but golang packaging just cumbersome and I'm not interested in being POC for any of golang packages. Sorry, guys. Still happy to co-maintain, but not primary maintainer. Feel free to takeover this review request (note that you don't need to create new one, but just give direct links for specs/srpms here and continue review). Here's an updated build spec: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00584845-git-lfs/git-lfs.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00584845-git-lfs/git-lfs-2.2.1-1.fc26.src.rpm We will need to resolve blockers first: https://bugzilla.redhat.com/show_bug.cgi?id=1336161 and https://bugzilla.redhat.com/show_bug.cgi?id=1336161 Replaced by new RR. *** This bug has been marked as a duplicate of bug 1487430 *** |