Bug 1410854

Summary:	glusterfs-server should depend on firewalld-filesystem
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	packaging	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs, kkeithle
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1410853	Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1410853
Bug Blocks:	1413283

Description Niels de Vos 2017-01-06 15:55:29 UTC

+++ This bug was initially created as a clone of Bug #1410853 +++

+++ This bug was initially created as a clone of Bug #1410852 +++

Description of problem:
Recently RHEL7 was rebased to have firewalld-filesystem available. Because the glusterfs-server RPM installs a .xml file with firewalld rules, this RPM needs to depend on the RPM that provides the directory for the .xml files.

Version-Release number of selected component (if applicable):
3.8 and newer

Additional info:
The glusterfs.spec.in currently tries to execute "firewall-cli --reload". The correct way is to call the %firewalld_reload macro from /usr/lib/rpm/macros.d/macros.firewalld (provided by firewalld-filesystem).

Comment 1 Worker Ant 2017-01-10 09:49:25 UTC

REVIEW: http://review.gluster.org/16369 (rpm: depend on firewalld-filesystem for directory ownership) posted (#1) for review on release-3.9 by Niels de Vos (ndevos)

Comment 2 Worker Ant 2017-01-10 09:54:17 UTC

REVIEW: http://review.gluster.org/16369 (rpm: depend on firewalld-filesystem for directory ownership) posted (#2) for review on release-3.9 by Niels de Vos (ndevos)

Comment 3 Worker Ant 2017-01-12 16:07:27 UTC

COMMIT: http://review.gluster.org/16369 committed in release-3.9 by Kaleb KEITHLEY (kkeithle) 
------
commit 60acdbd87a2c3d5bf1b199b91a7d154467fe1b79
Author: Niels de Vos <ndevos>
Date:   Tue Jan 10 10:49:07 2017 +0100

    rpm: depend on firewalld-filesystem for directory ownership
    
    Also use the %firewalld_reload macro that is provided by the
    firewalld-filesystem package.
    
    Cherry picked from commit f99750b4477538cd1f97ce6340e1813202f986e2:
    > BUG: 1410853
    > Change-Id: Ibbbc18cc394f8b1e5ba74927effc41c466667479
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/16351
    > Smoke: Gluster Build System <jenkins.org>
    > Tested-by: Kaleb KEITHLEY <kkeithle>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    
    Change-Id: Ibbbc18cc394f8b1e5ba74927effc41c466667479
    BUG: 1410854
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/16369
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 4 Worker Ant 2017-01-13 13:36:31 UTC

REVIEW: http://review.gluster.org/16409 (rpm: fix glusterfs-server(%postun) scriptlet error) posted (#1) for review on release-3.9 by Niels de Vos (ndevos)

Comment 5 Worker Ant 2017-01-13 20:16:55 UTC

COMMIT: http://review.gluster.org/16409 committed in release-3.9 by Kaleb KEITHLEY (kkeithle) 
------
commit f8a61095fc7003b97960d3097cfa2b6a3ad9fe43
Author: Niels de Vos <ndevos>
Date:   Fri Jan 13 14:31:27 2017 +0100

    rpm: fix glusterfs-server(%postun) scriptlet error
    
    While introducing the usage of the %firewalld_restart macro, the old
    scriplet was not correctly removed. This causes an error to be displayed
    when the RPM gets updated or uninstalled.
    
    Cherry picked from commit e3d09359b2090c0dc9160b693969f69ecda3477c:
    > Fixes: f99750b4477538cd1f97ce6340e1813202f986e2
    > Change-Id: I69091d8e9e3c412dc3cb52246967eac29d2ebc90
    > BUG: 1410853
    > Signed-off-by: Niels de Vos <ndevos>
    
    Fixes: 60acdbd87a2c3d5bf1b199b91a7d154467fe1b79
    Change-Id: I69091d8e9e3c412dc3cb52246967eac29d2ebc90
    BUG: 1410854
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/16409
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 6 Kaushal 2017-03-08 10:24:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 7 Kaushal 2017-03-08 10:24:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/