Bug 1463429

Summary:	Review Request: rust-srpm-macros - RPM macros for building Rust source packages
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-09 07:27:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1468545, 1475132

Description Igor Gnatenko 2017-06-20 21:41:08 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros-3-1.fc27.src.rpm
Description: RPM macros for building Rust source packages.
Fedora Account System Username: ignatenkobrain.

Comment 1 Neal Gompa 2017-07-08 21:16:18 UTC

Taking this review.

Comment 2 Neal Gompa 2017-07-08 21:21:18 UTC

Review notes:

+ Package named appropriately
+ Package follows general packaging guidelines
- Missing license file marked as %license

Please add the missing license file to the spec.

Comment 3 Igor Gnatenko 2017-07-08 21:26:16 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros-4-2.fc27.src.rpm

Fixed.

Comment 4 Neal Gompa 2017-07-08 21:27:13 UTC

Excellent.

PACKAGE APPROVED.

Comment 5 Gwyn Ciesla 2017-07-09 00:55:47 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rust-srpm-macros