Bug 1468545 - Review Request: rust-packaging - RPM macros for building Rust packages on various architectures
Summary: Review Request: rust-packaging - RPM macros for building Rust packages on var...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1463429
Blocks: 1475132
TreeView+ depends on / blocked
 
Reported: 2017-07-07 11:27 UTC by Igor Gnatenko
Modified: 2017-07-26 06:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-23 08:48:39 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Igor Gnatenko 2017-07-07 11:27:24 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-packaging.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-packaging-3-5.fc27.src.rpm
Description: The package provides macros for building projects in Rust
on various architectures.
Fedora Account System Username: ignatenkobrain
Comment 1 Neal Gompa 2017-07-08 21:17:07 UTC 
Taking this review.
Comment 2 Neal Gompa 2017-07-08 21:30:12 UTC 
Review notes:

+ Package named appropriately
+ Package follows general packaging guidelines
- Missing license file marked as %license

Please add the missing license file to the spec.
Comment 3 Igor Gnatenko 2017-07-08 21:31:52 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-packaging.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-packaging-4-2.fc27.src.rpm

Fixed.
Comment 4 Neal Gompa 2017-07-08 21:34:33 UTC 
The spec file doesn't match what the SRPM says. Please update the spec to match it.
Comment 5 Igor Gnatenko 2017-07-08 21:35:56 UTC 
weird, just re-uploaded
Comment 6 Neal Gompa 2017-07-08 21:50:32 UTC 
Excellent, everything looks great!

PACKAGE APPROVED.
Comment 7 Gwyn Ciesla 2017-07-09 00:56:34 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rust-packaging
Note You need to log in before you can comment on or make changes to this bug.