Bug 1463429 - Review Request: rust-srpm-macros - RPM macros for building Rust source packages
Summary: Review Request: rust-srpm-macros - RPM macros for building Rust source packages
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1468545 1475132
TreeView+ depends on / blocked
 
Reported: 2017-06-20 21:41 UTC by Igor Gnatenko
Modified: 2017-07-26 06:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-09 07:27:51 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Igor Gnatenko 2017-06-20 21:41:08 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros-3-1.fc27.src.rpm
Description: RPM macros for building Rust source packages.
Fedora Account System Username: ignatenkobrain.
Comment 1 Neal Gompa 2017-07-08 21:16:18 UTC 
Taking this review.
Comment 2 Neal Gompa 2017-07-08 21:21:18 UTC 
Review notes:

+ Package named appropriately
+ Package follows general packaging guidelines
- Missing license file marked as %license

Please add the missing license file to the spec.
Comment 3 Igor Gnatenko 2017-07-08 21:26:16 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-srpm-macros-4-2.fc27.src.rpm

Fixed.
Comment 4 Neal Gompa 2017-07-08 21:27:13 UTC 
Excellent.

PACKAGE APPROVED.
Comment 5 Gwyn Ciesla 2017-07-09 00:55:47 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rust-srpm-macros
Note You need to log in before you can comment on or make changes to this bug.