Bug 1468873
| Summary: | Review Request: python-click-plugins - Click extension to enable registering CLI commands via setuptools entry-points | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-31 14:54:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1468877 | ||
|
Description
Elliott Sales de Andrade
2017-07-09 08:26:54 UTC
Some informal reviews I have done: https://bugzilla.redhat.com/show_bug.cgi?id=1440992#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1440971#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1433757#c2 https://bugzilla.redhat.com/show_bug.cgi?id=1368855#c14 I like the following trick:
%global _description \
An extension module for click to register external CLI commands via setuptools\
entry-points.
%description %_description
%description -n python2-%{srcname} %_description
%description -n python3-%{srcname} %_description
... but of course repeating the description text is OK.
Minor nitpick: the description line is very long, dnf list will look ugly.
What about: "Click extension to register CLI commands via setuptools"?
This is nice and straightforward:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ follows the modern python packaging template
+ builds and installs OK
+ no scriptlets needed
+ %check is present and passes
+ %license macro is used
+ %python_provide is used
rpmlint:
Only false positive ramblings about toadstools.
Package is APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-click-plugins python-click-plugins-1.0.3-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cb75d0bea9 python-click-plugins-1.0.3-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cb75d0bea9 python-click-plugins-1.0.3-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |