Red Hat Bugzilla – Bug 1468877
Review Request: python-fiona - read and write spatial data files
Last modified: 2017-08-13 11:32:34 EDT
Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide-x86_64/00577188-python-fiona/python-fiona.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide-x86_64/00577188-python-fiona/python-fiona-1.7.8-2.fc27.src.rpm
Description: Fiona can read and write real-world data using multi-layered GIS formats and zipped virtual file systems and integrates readily with other Python GIS packages such as pyproj, Rtree, and Shapely.
This is my first package in Fedora proper; I am thus seeking a sponsor.
Fedora Account System Username: qulogic
Some informal reviews I have done:
It's generally better to not repeat the package name in Summary, since most of the time the package name is shown separately anyway (by dnf list, etc.).
The %description is also a bit off in my opinion: the most important part is what formats it can read and write. I'd move the last sentence to the beginning and add some information about what formats it supports (I don't know how many there are, but if it's possible, I'd just list them. This has the advantage that it'll show up in searches.)
I'd also recommend the trick from https://bugzilla.redhat.com/show_bug.cgi?id=1468873#c2 to avoid repeating the lengthy description text.
But those are all non-blocking issues.
python3-fiona.x86_64: W: no-manual-page-for-binary fio
That's not mandatory. Otherwise rpmlint says nothing useful.
+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ builds and install OK
+ %check is present and passes
+ modern python packaging template is used
+ R/P/BR look correct
+ %python_provide macros are present
+ %license macro is used
+ /usr/bin/fio runs OK
Package is APPROVED.
That's the first paragraph from PyPI: https://pypi.python.org/pypi/Fiona
Unfortunately, I cannot find a straightforward list of all supported formats.
Yes. It's also a bad description for pypi. (It contains too much "advertisting", and doesn't really give the one to two sentence summary of what this package "does".)
That's way too many to list :(