Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide-x86_64/00577183-python-click-plugins/python-click-plugins.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide-x86_64/00577183-python-click-plugins/python-click-plugins-1.0.3-2.fc27.src.rpm Description: This extension module for click allows registering external CLI commands via setuptools entry-points. This is my first package in Fedora proper; I am seeking a sponsor. Fedora Account System Username: qulogic
Some informal reviews I have done: https://bugzilla.redhat.com/show_bug.cgi?id=1440992#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1440971#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1433757#c2 https://bugzilla.redhat.com/show_bug.cgi?id=1368855#c14
I like the following trick: %global _description \ An extension module for click to register external CLI commands via setuptools\ entry-points. %description %_description %description -n python2-%{srcname} %_description %description -n python3-%{srcname} %_description ... but of course repeating the description text is OK. Minor nitpick: the description line is very long, dnf list will look ugly. What about: "Click extension to register CLI commands via setuptools"? This is nice and straightforward: + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + follows the modern python packaging template + builds and installs OK + no scriptlets needed + %check is present and passes + %license macro is used + %python_provide is used rpmlint: Only false positive ramblings about toadstools. Package is APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-click-plugins
python-click-plugins-1.0.3-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cb75d0bea9
python-click-plugins-1.0.3-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cb75d0bea9
python-click-plugins-1.0.3-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.