Bug 1483838
| Summary: | backport "--no-hostonly-default-device" dracut option | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Xunlei Pang <xlpang> |
| Component: | dracut | Assignee: | Lukáš Nykrýn <lnykryn> |
| Status: | CLOSED ERRATA | QA Contact: | Release Test Team <release-test-team-automation> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.5 | CC: | dracut-maint-list, dyoung, hannsj_uhl, jstodola, kdump-team-bugs, lnykryn, pkotvan, qzhao, ruyang, xiawu |
| Target Milestone: | rc | Keywords: | Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | dracut-033-513.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-10 18:07:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1431974, 1437029, 1460652 | ||
|
Description
Xunlei Pang
2017-08-22 05:55:52 UTC
Hi Lukas, could you please backport the feature to rhel7.5? We have several bugs dependent on this one and the customers want them to be fixed quickly. Looks backportable. I had to kinda modify the second patch to match the rhel7 code. https://github.com/lnykryn/dracut/commit/e2afcc958be19287bc23d9c0a052b5ac57bb3df3 Can you please try this scratch build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=14376384 According to test, rhel7 still lacks below commit, but I'm not sure if it depends on other commits.
commit 07a081f352497258862ae164d11d9e6dc2c5b959
Author: Harald Hoyer <harald>
Date: Fri Nov 13 13:40:38 2015 +0100
dracut.sh: remove the concept of host_modalias
We can never gather enough information about compiled in modules, so
don't pretend to know and do smart decisions.
Maybe we can go with below changes, it passed my test, what's your opinion?
The changes is based on dracus.sh in your scratch build
--- dracut 2017-10-27 14:57:26.401855223 +0800
+++ dracut.new 2017-10-27 15:34:11.948891591 +0800
@@ -1121,8 +1121,9 @@ if [[ $hostonly ]] && [[ "$hostonly_defa
[[ -b $_dev ]] && push host_devs "$_dev"
done < /etc/fstab
fi
+fi
-
+if [[ $hostonly ]] && [[ "$hostonly_default_device" != "no" ]]; then
# record all host modaliases
declare -A host_modalias
find /sys/devices/ -name uevent -print > "$initdir/.modalias"
Oops, should be be below changes which works for me:
--- dracut 2017-10-27 14:57:26.401855223 +0800
+++ dracut.new 2017-10-27 15:38:43.638591013 +0800
@@ -1121,8 +1121,10 @@ if [[ $hostonly ]] && [[ "$hostonly_defa
[[ -b $_dev ]] && push host_devs "$_dev"
done < /etc/fstab
fi
+fi
+if [[ $hostonly ]]; then
# record all host modaliases
declare -A host_modalias
find /sys/devices/ -name uevent -print > "$initdir/.modalias"
Backporting the whole patch would not probably cause any regressions, but let's be careful and let's just go with your solution https://github.com/dracutdevs/dracut/commit/0489607bf69ce521e1409e902380f3e168eeb302 https://github.com/dracutdevs/dracut/commit/e2afcc958be19287bc23d9c0a052b5ac57bb3df3 https://github.com/dracutdevs/dracut/commit/0e842c4b8b2796b9ae606da81ec92839af1cc27e Verified on with RHEL-7.5-20171130.0 dracut-033-520.el7. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0964 |