Red Hat Bugzilla – Bug 1483838
backport "--no-hostonly-default-device" dracut option
Last modified: 2018-04-10 14:10:22 EDT
Description of problem: kexec-tools needs this feature to remove needless devices under kdump. Two dracut upstream commits: commit 37f2fe55d dracut.sh: introduce "--no-hostonly-default-device" argument commit 5634a3115 rootfs-block/module-setup.sh: check root_devs in cmdline_rootfs() Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Hi Lukas, could you please backport the feature to rhel7.5? We have several bugs dependent on this one and the customers want them to be fixed quickly.
Looks backportable.
I had to kinda modify the second patch to match the rhel7 code. https://github.com/lnykryn/dracut/commit/e2afcc958be19287bc23d9c0a052b5ac57bb3df3 Can you please try this scratch build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=14376384
According to test, rhel7 still lacks below commit, but I'm not sure if it depends on other commits. commit 07a081f352497258862ae164d11d9e6dc2c5b959 Author: Harald Hoyer <harald@redhat.com> Date: Fri Nov 13 13:40:38 2015 +0100 dracut.sh: remove the concept of host_modalias We can never gather enough information about compiled in modules, so don't pretend to know and do smart decisions. Maybe we can go with below changes, it passed my test, what's your opinion? The changes is based on dracus.sh in your scratch build --- dracut 2017-10-27 14:57:26.401855223 +0800 +++ dracut.new 2017-10-27 15:34:11.948891591 +0800 @@ -1121,8 +1121,9 @@ if [[ $hostonly ]] && [[ "$hostonly_defa [[ -b $_dev ]] && push host_devs "$_dev" done < /etc/fstab fi +fi - +if [[ $hostonly ]] && [[ "$hostonly_default_device" != "no" ]]; then # record all host modaliases declare -A host_modalias find /sys/devices/ -name uevent -print > "$initdir/.modalias"
Oops, should be be below changes which works for me: --- dracut 2017-10-27 14:57:26.401855223 +0800 +++ dracut.new 2017-10-27 15:38:43.638591013 +0800 @@ -1121,8 +1121,10 @@ if [[ $hostonly ]] && [[ "$hostonly_defa [[ -b $_dev ]] && push host_devs "$_dev" done < /etc/fstab fi +fi +if [[ $hostonly ]]; then # record all host modaliases declare -A host_modalias find /sys/devices/ -name uevent -print > "$initdir/.modalias"
Backporting the whole patch would not probably cause any regressions, but let's be careful and let's just go with your solution
https://github.com/dracutdevs/dracut/commit/0489607bf69ce521e1409e902380f3e168eeb302 https://github.com/dracutdevs/dracut/commit/e2afcc958be19287bc23d9c0a052b5ac57bb3df3 https://github.com/dracutdevs/dracut/commit/0e842c4b8b2796b9ae606da81ec92839af1cc27e
Verified on with RHEL-7.5-20171130.0 dracut-033-520.el7.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0964