Bug 1491548

Summary:	change the path of gdeploy scripts files in the generated gdeploy conf file to /usr/share/ansible/gdeploy/scripts and rename black_list_all_devices to disable-multipath.sh
Product:	[oVirt] cockpit-ovirt	Reporter:	RamaKasturi <knarra>
Component:	Gdeploy	Assignee:	Gobinda Das <godas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	RamaKasturi <knarra>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	0.10.7-0.0.20	CC:	amarchuk, bugs, sabose
Target Milestone:	ovirt-4.1.6	Flags:	rule-engine: ovirt-4.1? ykaul: blocker+ knarra: planning_ack? rule-engine: devel_ack+ sasundar: testing_ack+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-dashboard-0.10.8-2.2.ovirt41.el7ev.noarch	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-16 10:09:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description RamaKasturi 2017-09-14 06:49:32 UTC

Description of problem:
Due to bug fix latest gdeploy which is not yet released needs to be tagged to RHV-H 4.1.6 other wise any new installtions of RHHI will break. To avoid this issue this bug is being raised to revert the path of script files to older path which is /usr/share/ansible/gdeploy/scripts.

With older version of ansible available script black_list_all_devices is not present. So this has to be renamed back to disable-multipath.sh.

Version-Release number of selected component (if applicable):
cockpit-ovirt-dashboard-0.10.8-2.0.ovirt41.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Install latest RHV-H ISO
2. Start configuring gluster
3.

Actual results:
If gdeploy is not updated to latest which is gdeploy-2.0.2-14.el7rhgs.noarch then new installations of RHHI will break due to the change in gdeploy script file path.

Expected results:
path for gdeploy script files have to be changed to old path which is /usr/share/ansible/gdeploy/scripts

Rename the script back to disable-multipath.sh

Additional info:

[root@rhsqa-grafton4 ~]# ls -l /usr/share/ansible/gdeploy/scripts/
total 12
-rwxr-xr-x. 1 root root  512 May 12 17:34 disable-gluster-hooks.sh
-rwxr-xr-x. 1 root root  160 May 12 17:34 disable-multipath.sh
-rwxr-xr-x. 1 root root 3476 May 12 17:34 grafton-sanity-check.sh

Comment 1 SATHEESARAN 2017-09-14 07:00:17 UTC

Additional info

The following bugs brought in the required change earlier for RHHI 1.1 product, which includes gdeploy-2.0.2-14.el7rhgs as part of RHGS 3.3.0 

https://bugzilla.redhat.com/show_bug.cgi?id=1462082
https://bugzilla.redhat.com/show_bug.cgi?id=1469469

The fixes for these bugs needs to be reverted, as the latest gdeploy is still not available

Comment 2 RamaKasturi 2017-09-19 13:12:19 UTC

verified and works fine with build cockpit-ovirt-dashboard-0.10.8-2.2.ovirt41.el7ev.noarch.

With this build i see that gdeploy script file path has been changed to /usr/share/ansible/gdeploy/scripts.

[script1]
action=execute
ignore_script_errors=no
file=/usr/share/ansible/gdeploy/scripts/grafton-sanity-check.sh -d sdc -h 10.70.36.79,10.70.36.80,10.70.36.81

[script3]
action=execute
file=/usr/share/ansible/gdeploy/scripts/disable-multipath.sh
ignore_script_errors=no

[script2]
action=execute
file=/usr/share/ansible/gdeploy/scripts/disable-gluster-hooks.sh



And black_list_all_devices has been renamed to disable-multipath.sh and the script has older code which stops and disables multipathd.

[root@rhsqa-grafton1 ~]# cat /usr/share/ansible/gdeploy/scripts/disable-multipath.sh 
#!/usr/bin/env bash

multipath -F
cat <<EOF>> /etc/multipath.conf
blacklist {
        devnode "*"
}
EOF

systemctl stop multipathd
systemctl disable multipathd