Bug 150277

Summary: problems renaming tmpfile to outfile
Product: [Fedora] Fedora Reporter: Stephen Beahm <stephenbeahm>
Component: dos2unixAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: 3CC: danielc, laroche, w.milek
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 3.1-24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-04-13 14:38:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for this problem none

Description Stephen Beahm 2005-03-04 07:22:01 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3)
Gecko/20041020 Epiphany/1.4.4

Description of problem:
The problem is in 'dos2unix-3.1-tmppath.patch'. Memory for the null
terminator is not being allocated.

this code:
fname_len = strlen(dir) + strlen("/d2utmpXXXXXX");

should be:
fname_len = strlen(dir) + strlen("/d2utmpXXXXXX") + sizeof(char);

Version-Release number of selected component (if applicable):
dos2unix-3.1-21

How reproducible:
Sometimes

Steps to Reproduce:
1. dos2unix ./source/common/launch.h

    

Actual Results:  dos2unix: converting file ./source/common/launch.h to
UNIX format ...
dos2unix: problems renaming './source/common/d2utmptfS3dJ' to
'./source/common/launch.h'
          output file remains in './source/common/d2utmptfS3dJ'

Additional info:

Comment 1 Vladimir Kondratiev 2005-03-29 11:55:27 UTC
I observe the same problem;
fix described in original report do work for me. Looks like fix is correct.

Comment 2 Tim Waugh 2005-04-13 09:02:06 UTC
*** Bug 143359 has been marked as a duplicate of this bug. ***

Comment 3 Tim Waugh 2005-04-13 14:38:15 UTC
Fixed in 3.1-24.

Comment 4 Tim Waugh 2005-09-29 12:46:33 UTC
*** Bug 169527 has been marked as a duplicate of this bug. ***

Comment 5 Wojciech Milek 2005-09-29 12:50:45 UTC
Created attachment 119415 [details]
Patch for this problem

This patch fixes allocation problem

Comment 6 Tim Waugh 2006-03-23 23:10:24 UTC
*** Bug 186490 has been marked as a duplicate of this bug. ***