Bug 1595767
| Summary: | [RFE] Don't show allocated IPs in dropdown while assigning floating IPs via CloudForms | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Niladri Roy <niroy> | ||||
| Component: | Providers | Assignee: | Gilles Dubreuil <gdubreui> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ido Ovadia <iovadia> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.9.0 | CC: | bgillet, gblomqui, gdubreui, gekis, iovadia, jfrey, jhardy, jocarter, lavenel, lmiccini, niroy, obarenbo, pmukhedk, simaishi, smallamp | ||||
| Target Milestone: | GA | Keywords: | FutureFeature, TestOnly, ZStream | ||||
| Target Release: | 5.10.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.10.0.25 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1623562 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-02-11 14:07:01 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | Openstack | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1623562 | ||||||
| Attachments: |
|
||||||
|
Comment 2
Bronagh Sorota
2018-06-27 14:55:40 UTC
Hi Bronagh, This is for OpenStack provider this RFE is raised because of BZ 1590828 Hi Niladri, They look like duplicate BZs, can you clarify why we have both? Thanks Bronagh Further to my own question in #comment4, I closed BZ 1590828 Just to clarify BZ#1590828 was targeting CF 5.9.x and defined as a bug. This is an RFE for future CF versions and could be eventually ported back. Some users might want to be able to reallocate Floating IPs directly while others might not want to and be forced to de-allocate them first. Since one cannot have both, any choice would make the other half unhappy. Alternatively have a preference option that toggle between the two, although that would be a bit more effort. PM to help with the decision, please. Hi, So to avoid a duplicate I have search and found this RFE and it's ON_DEV counterpart. I have a somewhat related, but also somewhat different issue on this topic. (On cfme 5.9.4 vs. OSP 13) If a user wants to allocate one of it's tenant free floating IPs, and that there are free floating IPs then they are correctly listed and he may do the thing perfectly. Now, if there are no more free floating IPs for it's tenant he is proposed the totality of Floating IPs within all tenants, should they be allocated or free, without giving any clue about their status. He can make it's choice that will lead to nothing without error. Is it an issue that will be addressed in this RFE or should I open a bugzilla for it ? Thanks, Bruno. (In reply to Gilles Dubreuil from comment #10) > https://github.com/ManageIQ/manageiq-ui-classic/pull/4357 Gilles, is this the only change needed? I get a bunch of "undefined" by applying it to my test appliance (see screenshot). thanks Luca Created attachment 1483385 [details]
floatingip selection menu
@Luca, Definitely not was is expected and what I experience. Let me test with latest 5.9 and get back to you. In comment#15, please read Definitely not what is expected... @bruno, The idea of this patch is to make sure to offer to the user only the list of available floating IPs by excluding the floating IPs which are already assigned to an instance. If there are no more floating IPs available in the pool then the pool should be extended. If that's not what you meant then please clarify. Thanks (In reply to Gilles Dubreuil from comment #17) > @bruno, > > The idea of this patch is to make sure to offer to the user only the list of > available floating IPs by excluding the floating IPs which are already > assigned to an instance. > > If there are no more floating IPs available in the pool then the pool should > be extended. > > If that's not what you meant then please clarify. > > Thanks @Gilles, Your precision is exactly what my concern is about. I was not sure asking at the good place, and the original description did not explicitely covered extra tenant floating IPs that may appear, and especially only as no more available Floating IPs existed in current user tenant. Thanks for the precision. This RFE totally covers the need. Just tested latest upstream version and the list of floating IPs is not showing properly. Investigating. Only the first filtered floating IP is returned The following contains the change to return a list: https://github.com/ManageIQ/manageiq-ui-classic/pull/4944 The latter allows a non assigned floating IP can be associated to a VM. Meanwhile if VM has already an address, it must be disassociated first. New commit detected on ManageIQ/manageiq-ui-classic/hammer: https://github.com/ManageIQ/manageiq-ui-classic/commit/bf21dadc0908531b7ca2cf0397ea2a23b35cc8c6 commit bf21dadc0908531b7ca2cf0397ea2a23b35cc8c6 Author: Milan Zázrivec <mzazrivec> AuthorDate: Tue Nov 20 06:37:41 2018 -0500 Commit: Milan Zázrivec <mzazrivec> CommitDate: Tue Nov 20 06:37:41 2018 -0500 Merge pull request #4944 from gildub/vm_cloud_floating_ip VM CLoud: floating ips to associate must be a list (cherry picked from commit 911a289574b1d433c6a8fcde890ebb39d7f24da2) https://bugzilla.redhat.com/show_bug.cgi?id=1595767 app/controllers/mixins/actions/vm_actions/associate_floating_ip.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) *** Bug 1650495 has been marked as a duplicate of this bug. *** Verified ======== 5.10.0.28 |