Bug 166192
Summary: | Review Request: perl-Class-DBI-Plugin : Abstract base class for Class::DBI plugins | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-package-review | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://search.cpan.org/dist/Class-DBI-Plugin/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-08-31 23:38:49 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 166184 | ||||||
Bug Blocks: | 163779, 166193, 166194 | ||||||
Attachments: |
|
Description
Tom "spot" Callaway
2005-08-17 20:36:37 UTC
Review: - rpmlint clean - package and spec name OK - package meets guidelines - license same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds OK in mock on FC4 (i386) - no locales, libraries, subpackages or pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Nitpick: - BR: perl is redundant - add %{?_smp_mflags} to "make" - add BR: perl(DBD::SQLite) perl(SQL::Abstract) for extra test cover - license text missing; suggest usual fix Created attachment 118138 [details]
Patch addressing review issues
-3 has these items fixed. SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-0.03-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin.spec Approved. Please use "-t" option to "perldoc"; sorry I forgot that in patch. |