Bug 1680372

Summary:	Review Request: perl-GitLab-API-v4 - Complete GitLab API v4 client
Product:	[Fedora] Fedora	Reporter:	Björn Esser (besser82) <besser82>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-01 02:38:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1680373, 1680374, 1680375, 1680376
Bug Blocks:	1680371

Description Björn Esser (besser82) 2019-02-24 11:29:44 UTC

Description:

  This module provides a one-to-one interface with the GitLab API v4.
  Much is not documented here as it would just be duplicating GitLab's
  own API Documentation.


Issues:

  fedora-review shows no obvious issues.  rpmlint is silent.


FAS-User:

  besser82


Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/perl-GitLab-API-v4.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/perl-GitLab-API-v4-0.17-0.1.fc31.src.rpm


Thanks for review in advance!

Comment 1 Björn Esser (besser82) 2019-02-24 12:32:30 UTC

=== Updated package ===

Changelog:

  * Sun Feb 24 2019 Björn Esser <besser82> - 0.17-0.2
  - Added explicit perl module compat requires


Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/perl-GitLab-API-v4.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/perl-GitLab-API-v4-0.17-0.2.fc31.src.rpm

Comment 2 Björn Esser (besser82) 2019-02-24 16:10:38 UTC

Unassigning reviewer, resetting status to NEW.

Comment 3 Robert-André Mauchin 🐧 2019-02-24 17:47:18 UTC

URL and Source addresses are Ok.
Source archive (SHA-256: 9ffb4554a3c98273b6622181e81c6e18c3c6d02eebf3d8524cc3f017d613cecc) is original. Ok.
Summary verified from lib/GitLab/API/v4.pm. Ok.
Description verified from lib/GitLab/API/v4.pm. Ok.
License verified from lib/GitLab/API/v4.pm and README.md. Ok.
No XS code, noarch BuildArch is Ok.


$ rpmlint perl-GitLab-API-v4.spec review-perl-GitLab-API-v4/results/perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm review-perl-GitLab-API-v4/results/perl-GitLab-API-v4-0.17-0.2.fc31.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.


$ rpm -q -lv -p perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm 
-rwxr-xr-x    1 root    root                     5289 févr. 20 23:48 /usr/bin/gitlab-api-v4
drwxr-xr-x    2 root    root                        0 févr. 24 18:35 /usr/share/doc/perl-GitLab-API-v4
-rw-r--r--    1 root    root                     4808 févr. 20 23:48 /usr/share/doc/perl-GitLab-API-v4/Changes
-rw-r--r--    1 root    root                   117576 févr. 20 23:48 /usr/share/doc/perl-GitLab-API-v4/README.md
drwxr-xr-x    2 root    root                        0 févr. 24 18:35 /usr/share/licenses/perl-GitLab-API-v4
-rw-r--r--    1 root    root                    18424 févr. 20 23:48 /usr/share/licenses/perl-GitLab-API-v4/LICENSE
-rw-r--r--    1 root    root                     2915 févr. 24 18:35 /usr/share/man/man1/gitlab-api-v4.1.gz
-rw-r--r--    1 root    root                    15774 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4.3pm.gz
-rw-r--r--    1 root    root                     2940 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::Config.3pm.gz
-rw-r--r--    1 root    root                     2387 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::Constants.3pm.gz
-rw-r--r--    1 root    root                     2649 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::Paginator.3pm.gz
-rw-r--r--    1 root    root                     2118 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::RESTClient.3pm.gz
drwxr-xr-x    2 root    root                        0 févr. 24 18:35 /usr/share/perl5/vendor_perl/GitLab
drwxr-xr-x    2 root    root                        0 févr. 24 18:35 /usr/share/perl5/vendor_perl/GitLab/API
drwxr-xr-x    2 root    root                        0 févr. 24 18:35 /usr/share/perl5/vendor_perl/GitLab/API/v4
-rw-r--r--    1 root    root                   360668 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4.pm
-rw-r--r--    1 root    root                     5791 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4/Config.pm
-rw-r--r--    1 root    root                     3157 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4/Constants.pm
-rw-r--r--    1 root    root                     4008 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4/Paginator.pm
File permissions and layout are Ok.

rpm -q --requires -p perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm | sort -f | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Carp)
      1 perl(Const::Fast)
      1 perl(Exporter)
      1 perl(Getopt::Long)
      1 perl(GitLab::API::v4)
      1 perl(GitLab::API::v4::Config)
      1 perl(GitLab::API::v4::Constants)
      1 perl(GitLab::API::v4::Paginator)
      1 perl(GitLab::API::v4::RESTClient)
      1 perl(HTTP::Tiny)
      1 perl(HTTP::Tiny::Multipart)
      1 perl(IO::Prompter)
      1 perl(JSON)
      1 perl(Log::Any)
      1 perl(Log::Any::Adapter)
      1 perl(Log::Any::Adapter::Screen)
      1 perl(Moo)
      1 perl(namespace::clean)
      1 perl(Path::Tiny)
      1 perl(Pod::Usage)
      1 perl(strictures) >= 2
      1 perl(Try::Tiny)
      1 perl(Types::Common::Numeric)
      1 perl(Types::Common::String)
      1 perl(Types::Standard)
      1 perl(URI)
      1 perl(URI::Escape)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

 - Add BR for test:

BuildRequires:  perl(IPC::Cmd)


$ rpm -q --provides -p perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm 
perl(GitLab::API::v4) = 0.17
perl(GitLab::API::v4::Config) = 0.17
perl(GitLab::API::v4::Constants) = 0.17
perl(GitLab::API::v4::Paginator) = 0.17
perl(GitLab::API::v4::RESTClient) = 0.17
perl-GitLab-API-v4 = 0.17-0.2.fc31

Package builds in Mock. Ok

Resolution: Package not approved. Please fix all the aforementioned points.

Comment 4 Robert-André Mauchin 🐧 2019-02-24 17:51:17 UTC

I have to go.

Package approved, but add the missing BR before import.

Comment 5 Björn Esser (besser82) 2019-02-24 17:59:19 UTC

(In reply to Robert-André Mauchin from comment #4)
> I have to go.
> 
> Package approved, but add the missing BR before import.

Thank you very much for doing all the reviews!!!

Your remarks have been addressed.

***

=== Updated package ===

Changelog:

  * Sun Feb 24 2019 Björn Esser <besser82> - 0.17-0.3
  - Changes as suggested in review (#1680372)
  - Add a set of explicit BuildRequires


Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/perl-GitLab-API-v4.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/perl-GitLab-API-v4-0.17-0.3.fc31.src.rpm

Comment 6 Gwyn Ciesla 2019-02-25 15:01:17 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-GitLab-API-v4

Comment 7 Fedora Update System 2019-02-25 17:20:13 UTC

perl-GitLab-API-v4-0.17-1.fc29 perl-HTTP-Tiny-Multipart-0.08-1.fc29 perl-IO-Prompter-0.004015-1.fc29 perl-Log-Any-Adapter-Screen-0.140-1.fc29 perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f

Comment 8 Fedora Update System 2019-02-25 17:23:57 UTC

devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050

Comment 9 Fedora Update System 2019-02-25 17:25:34 UTC

devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050

Comment 10 Fedora Update System 2019-02-25 17:25:52 UTC

devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050

Comment 11 Fedora Update System 2019-02-26 02:11:47 UTC

devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050

Comment 12 Fedora Update System 2019-02-26 04:11:19 UTC

perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f

Comment 13 Fedora Update System 2019-03-01 02:38:49 UTC

perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2019-03-06 15:27:35 UTC

devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.