Bug 1688300

Summary:	Review Request: perl-Geo-Point - Geographical primitives
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Geo-Point-0.98-1.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-14 10:50:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1688167, 1688292
Bug Blocks:

Description Petr Pisar 2019-03-13 13:43:21 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Geo-Point/perl-Geo-Point.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Geo-Point/perl-Geo-Point-0.98-1.fc31.src.rpm
Description:
These Perl modules provide geographical primitives like points, lines,
projections, or polygons. This is implemented as an abstraction above PROJ
library.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-13 15:32:31 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Geo-Point-0.98-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(Geo::Distance) >= 0.06
      1 perl(Geo::Line)
      1 perl(Geo::Point)
      1 perl(Geo::Proj)
      1 perl(Geo::Proj4) >= 1.01
      1 perl(Geo::Shape)
      1 perl(Geo::Space)
      1 perl(Geo::Surface)
      1 perl(List::Util)
      1 perl(Math::Polygon) >= 1.01
      1 perl(Math::Polygon::Calc)
      1 perl(Math::Polygon::Surface)
      1 perl(Math::Trig) >= 1
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Geo-Point-0.98-1.fc31.noarch.rpm | sort | uniq -c
Binary provides are Ok.

$ rpmlint ./perl-Geo-Point*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Igor Raits 2019-03-14 09:27:18 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Geo-Point

Comment 3 Petr Pisar 2019-03-14 10:50:15 UTC

Thank you for the review and the repository.