Bug 1745298

Summary:	[RFE] Add installer to virtio-win iso
Product:	Red Hat Enterprise Linux 8	Reporter:	Gal Zaidman <gzaidman>
Component:	virtio-win	Assignee:	Gal Zaidman <gzaidman>
virtio-win sub component:	distribution	QA Contact:	lijin <lijin>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	ailan, crobinso, dblechte, ddepaula, jen, jherrman, juzhang, kanderso, knoel, lijin, michal.skrivanek, mtessun, rbarry, sbonazzo, uril, vrozenfe
Version:	8.0	Keywords:	FutureFeature, RFE
Target Milestone:	rc	Flags:	gzaidman: needinfo-
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virtio-win-1.9.10-2.el8	Doc Type:	Enhancement
Doc Text:	.A new installer for virtio-win drivers An interactive Windows Installer has been added to the _virtio-win_ package. This makes it possible to easily and efficiently install paravirtualized KVM drivers in virtual machines that use Microsoft Windows as their guest operating systems.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-04 12:27:28 UTC	Type:	Feature Request
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1745303
Bug Blocks:	1728987, 1745324

Description Gal Zaidman 2019-08-25 06:41:55 UTC

Description of problem:

At the current state we don't have a msi to install virtio-win drivers,
We want to have a msi as part of virtio-win iso to install all the drivers and relevant agents.

Comment 1 Gal Zaidman 2019-08-25 07:12:39 UTC

This is an RFE that we at RHV-integ have been working on for a long time with the virtio-win team.

Preferred adding the current state on a comment:
At the current state we have a pre-whql build (947757) that is prepered for the msi.
We have an upstream GitHub project https://github.com/virtio-win/virtio-win-guest-tools-installer,
that creates a msi based on Wix toolset that will soon be built upstream as part of the iso.

Comment 17 lijin 2019-11-20 08:36:25 UTC

If you don't mind, may I ask a question about the proposal?

It seems the requested package is quite similar to rhv-guest-tools-iso: 
https://brewweb.engineering.redhat.com/brew/packageinfo?packageID=64501

# ll /usr/share/rhv-guest-tools-iso/
total 402420
-rw-r--r--. 1 root root    177272 Jul 17 10:27 LICENSES
-rw-r--r--. 1 root root 411893760 Jul 17 10:27 RHV-toolsSetup_4.3_10.iso
lrwxrwxrwx. 1 root root        25 Jul 17 10:27 rhv-tools-setup.iso -> RHV-toolsSetup_4.3_10.iso
-rw-r--r--. 1 root root       923 Jul 17 10:27 SOURCES

# mount /usr/share/rhv-guest-tools-iso/rhv-tools-setup.iso /home/mnt/
mount: /home/mnt: WARNING: device write-protected, mounted read-only.

# ll /home/mnt/
total 147095
-r-xr-xr-x.  1 root root   2290112 Jan  1  2013  CDHashes.txt
dr-xr-xr-x. 11 root root      2048 Jul 17 09:55  Drivers
dr-xr-xr-x.  7 root root      2048 Jul 17 09:55  linux
dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  Manifest
dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  QJScriptLib
-r--r--r--.  1 root root  12536736 Jul 17 09:55 'RHEV-Application Provisioning Tool.exe'
dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  RHEV-apt
-r--r--r--.  1 root root 135777856 Jul 17 09:55  RHEV-toolsSetup.exe
dr-xr-xr-x.  2 root root      6144 Jul 17 09:55  tools
dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  Upgrade
-r--r--r--.  1 root root      1100 Jul 17 09:55  Upgrade.wsf

I remember RHEV-toolsSetup.exe will install related drivers and agents.

# ll /home/mnt/tools/
total 164595
-r--r--r--. 1 root root  7249408 Jul 17 09:55 RHEV-Agent64.msi
-r--r--r--. 1 root root  6028288 Jul 17 09:55 RHEV-Agent.msi
-r--r--r--. 1 root root 13827072 Jul 17 09:55 RHEV-Balloon64.msi
-r--r--r--. 1 root root 11875328 Jul 17 09:55 RHEV-Balloon.msi
-r--r--r--. 1 root root  5035008 Jul 17 09:55 RHEV-Block64.msi
-r--r--r--. 1 root root  4606464 Jul 17 09:55 RHEV-Block.msi
-r--r--r--. 1 root root  6700544 Jul 17 09:55 RHEV-Network64.msi
-r--r--r--. 1 root root  5676032 Jul 17 09:55 RHEV-Network.msi

# ll /home/mnt/Drivers/
total 18
dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 Balloon
dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 NetKVM
dr-xr-xr-x.  4 root root 2048 Jul 17 09:55 qemufwcfg
dr-xr-xr-x.  6 root root 2048 Jul 17 09:55 qxl
dr-xr-xr-x.  3 root root 2048 Jul 17 09:55 smbus
dr-xr-xr-x. 11 root root 2048 Jul 17 09:55 viorng
dr-xr-xr-x. 11 root root 2048 Jul 17 09:55 vioscsi
dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 vioserial
dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 viostor


So why can't we continue to use rhv-guest-tools-iso?

Comment 18 Gal Zaidman 2019-11-21 08:15:56 UTC

(In reply to lijin from comment #17)
> If you don't mind, may I ask a question about the proposal?
> 
> It seems the requested package is quite similar to rhv-guest-tools-iso: 
> https://brewweb.engineering.redhat.com/brew/packageinfo?packageID=64501
> 
> # ll /usr/share/rhv-guest-tools-iso/
> total 402420
> -rw-r--r--. 1 root root    177272 Jul 17 10:27 LICENSES
> -rw-r--r--. 1 root root 411893760 Jul 17 10:27 RHV-toolsSetup_4.3_10.iso
> lrwxrwxrwx. 1 root root        25 Jul 17 10:27 rhv-tools-setup.iso ->
> RHV-toolsSetup_4.3_10.iso
> -rw-r--r--. 1 root root       923 Jul 17 10:27 SOURCES
> 
> # mount /usr/share/rhv-guest-tools-iso/rhv-tools-setup.iso /home/mnt/
> mount: /home/mnt: WARNING: device write-protected, mounted read-only.
> 
> # ll /home/mnt/
> total 147095
> -r-xr-xr-x.  1 root root   2290112 Jan  1  2013  CDHashes.txt
> dr-xr-xr-x. 11 root root      2048 Jul 17 09:55  Drivers
> dr-xr-xr-x.  7 root root      2048 Jul 17 09:55  linux
> dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  Manifest
> dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  QJScriptLib
> -r--r--r--.  1 root root  12536736 Jul 17 09:55 'RHEV-Application
> Provisioning Tool.exe'
> dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  RHEV-apt
> -r--r--r--.  1 root root 135777856 Jul 17 09:55  RHEV-toolsSetup.exe
> dr-xr-xr-x.  2 root root      6144 Jul 17 09:55  tools
> dr-xr-xr-x.  2 root root      2048 Jul 17 09:55  Upgrade
> -r--r--r--.  1 root root      1100 Jul 17 09:55  Upgrade.wsf
> 
> I remember RHEV-toolsSetup.exe will install related drivers and agents.
> 
> # ll /home/mnt/tools/
> total 164595
> -r--r--r--. 1 root root  7249408 Jul 17 09:55 RHEV-Agent64.msi
> -r--r--r--. 1 root root  6028288 Jul 17 09:55 RHEV-Agent.msi
> -r--r--r--. 1 root root 13827072 Jul 17 09:55 RHEV-Balloon64.msi
> -r--r--r--. 1 root root 11875328 Jul 17 09:55 RHEV-Balloon.msi
> -r--r--r--. 1 root root  5035008 Jul 17 09:55 RHEV-Block64.msi
> -r--r--r--. 1 root root  4606464 Jul 17 09:55 RHEV-Block.msi
> -r--r--r--. 1 root root  6700544 Jul 17 09:55 RHEV-Network64.msi
> -r--r--r--. 1 root root  5676032 Jul 17 09:55 RHEV-Network.msi
> 
> # ll /home/mnt/Drivers/
> total 18
> dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 Balloon
> dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 NetKVM
> dr-xr-xr-x.  4 root root 2048 Jul 17 09:55 qemufwcfg
> dr-xr-xr-x.  6 root root 2048 Jul 17 09:55 qxl
> dr-xr-xr-x.  3 root root 2048 Jul 17 09:55 smbus
> dr-xr-xr-x. 11 root root 2048 Jul 17 09:55 viorng
> dr-xr-xr-x. 11 root root 2048 Jul 17 09:55 vioscsi
> dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 vioserial
> dr-xr-xr-x. 13 root root 2048 Jul 17 09:55 viostor
> 
> 
> So why can't we continue to use rhv-guest-tools-iso?

RHV-guest-tools was based on a proprietary software called InstallShield, that is the historic reason it wasn't part of virtio-win in the first place.
Now I build a replacement for RHV-guest-tools using wix-toolset which is opensource.
I proposed adding it to virtio-win because well it make a lot more sense to have the installer with the drivers, plus it adds value to our costumers :)

Comment 22 lijin 2019-12-18 09:01:04 UTC

win2012:
all drivers are NOT installed on win2012 guest after installer execution finishes, reboot does not work neither.

win8, win8.1, and win2012R2:
check pvpanic/rng/baloon/serial/blk/scsi/netkvm/qemuserialpci drivers in device manager, all drivers are installed correctly;

win10, win2016 and win2019:
check pvpanic/rng/baloon/serial/blk/scsi/netkvm/qemuserialpci/qemufwcfg drivers in device manager, all drivers are installed correctly;

vioinput driver are not installed on all windows guests, file bz1784745 to track it;

installer remove operation uninstall all drivers including system disk driver which will casue guest bsod, file bz1784744 to track it.

Comment 23 lijin 2019-12-18 09:39:53 UTC

(In reply to lijin from comment #22)
> win2012:
> all drivers are NOT installed on win2012 guest after installer execution
> finishes, reboot does not work neither.

After confirm with Gal, he prefer to use a new bug to track this issue, so I file bz1784760.

Change status to verified.

Comment 25 errata-xmlrpc 2020-02-04 12:27:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0351