Bug 1781095

Summary: Hide partial engine-cleanup option
Product: [oVirt] ovirt-engine Reporter: Yedidyah Bar David <didi>
Component: Setup.CoreAssignee: Yedidyah Bar David <didi>
Status: CLOSED CURRENTRELEASE QA Contact: Guilherme Santos <gdeolive>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.3.6.7CC: bugs, dfodor, mtessun, rdlugyhe, sbonazzo, sgoodman
Target Milestone: ovirt-4.4.0Keywords: ZStream
Target Release: ---Flags: pm-rhel: ovirt-4.4+
sbonazzo: devel_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Before this update, the engine-cleanup command enabled you to do a partial cleanup by prompting you to select which components to remove, even though partial cleanup is not supported. This resulted in a broken system. With this update, the prompt no longer appears and only full cleanup is possible.
Story Points: ---
Clone Of:
: 1792874 (view as bug list) Environment:
Last Closed: 2020-05-20 20:04:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1792874    

Description Yedidyah Bar David 2019-12-09 10:29:25 UTC
Description of problem:

When running engine-cleanup, it asks:

    Do you want to remove all components? (Yes, No) [Yes]: 

If you reply No, it asks you what components to remove, but nevertheless removes also other stuff, leaving the system partially broken. We had in the past bug 1060529 for doing this, but it was eventually closed due to lack of interest.

We should somehow make it clear that 'No' is not supported. Perhaps add a warning, confirm, or require setting some env key to enable this.

Comment 1 Yedidyah Bar David 2019-12-23 11:38:59 UTC
Sandro, I think we want this fixed also in 4.3. What do you think?

Comment 2 Yedidyah Bar David 2019-12-23 11:39:40 UTC
See also bug 1773704.

Comment 3 Sandro Bonazzola 2020-01-07 12:10:02 UTC
I would prefer not changing too much UX especially so late in 4.3 life. Martin?

Comment 4 Martin Tessun 2020-01-17 08:07:48 UTC
(In reply to Sandro Bonazzola from comment #3)
> I would prefer not changing too much UX especially so late in 4.3 life.
> Martin?

Well ... 4.3 will be around for quite some time. We should at least document that partial cleanup is not supported and may break your installation in the docs.

Comment 6 RHV bug bot 2020-01-24 19:50:30 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'ovirt-engine-4.4.0' doesn't contain patch 'https://gerrit.ovirt.org/105239']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.4.0

For more info please contact: infra

Comment 7 Guilherme Santos 2020-03-23 21:07:29 UTC
Verified on:
ovirt-engine-4.4.0-0.25.master.el8ev.noarch

Steps:
1. # engine-cleanup

Results:
Cleanup done successfully without asking if should remove all components

Comment 8 Sandro Bonazzola 2020-05-20 20:04:08 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.