+++ This bug is an upstream to downstream clone. The original bug is: +++ +++ bug 1781095 +++ ====================================================================== Description of problem: When running engine-cleanup, it asks: Do you want to remove all components? (Yes, No) [Yes]: If you reply No, it asks you what components to remove, but nevertheless removes also other stuff, leaving the system partially broken. We had in the past bug 1060529 for doing this, but it was eventually closed due to lack of interest. We should somehow make it clear that 'No' is not supported. Perhaps add a warning, confirm, or require setting some env key to enable this. (Originally by didi)
Sandro, I think we want this fixed also in 4.3. What do you think? (Originally by didi)
See also bug 1773704. (Originally by didi)
I would prefer not changing too much UX especially so late in 4.3 life. Martin? (Originally by Sandro Bonazzola)
(In reply to Sandro Bonazzola from comment #3) > I would prefer not changing too much UX especially so late in 4.3 life. > Martin? Well ... 4.3 will be around for quite some time. We should at least document that partial cleanup is not supported and may break your installation in the docs. (Originally by Martin Tessun)
Looking at the patch: 'Removing only some components is not supported. If you reply ' 'No, you will be prompted for components to be removed, ' 'but regardless of which ones you choose, the engine will ' 'not be functional. Some parts of the configuration are ' 'removed unconditionally. If unsure, stop this utility, e.g. ' 'by pressing Ctrl-C.' This does not seem to me like good UX to ask for answers and potentially ignore them, can we rather disable partial cleanup questions?
(In reply to Lukas Svaty from comment #6) > Looking at the patch: > > 'Removing only some components is not supported. If you reply ' > 'No, you will be prompted for components to be removed, ' > 'but regardless of which ones you choose, the engine will ' > 'not be functional. Some parts of the configuration are ' > 'removed unconditionally. If unsure, stop this utility, e.g. ' > 'by pressing Ctrl-C.' > > This does not seem to me like good UX to ask for answers and potentially > ignore them, can we rather disable partial cleanup questions? Not sure what you mean. Did you try this? Copying my own verification steps from the patch on master, https://gerrit.ovirt.org/105847 : Verified: 1. engine-cleanup does not ask anymore, defaults to remove all. 2. engine-cleanup --otopi-environment=OVESETUP_REMOVE/removeAll=none:None Prompts, warns both before the prompt and after it 3. engine-cleanup --otopi-environment=OVESETUP_REMOVE/removeAll=bool:False Warns once and does not prompt. User should still notice, because it then prompts for the first component to remove. See also bug 1773704 and bug 1060529.
Did not try, just checked patch, sounds good!
Verified on ovirt-engine-4.3.9.1-0.1.el7.noarch
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:1308