Bug 1785983

Summary: Review Request: python-flask-socketio - Socket.IO integration for Flask applications
Product: [Fedora] Fedora Reporter: Mukundan Ragavan <nonamedotc>
Component: Package ReviewAssignee: Zbigniew Jędrzejewski-Szmek <zbyszek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mail, package-review, zbyszek
Target Milestone: ---Flags: zbyszek: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-19 10:16:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1785981    
Bug Blocks: 1785970    

Description Mukundan Ragavan 2019-12-22 23:06:09 UTC 
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/flask-socketio/rnd1/python-flask-socketio.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/flask-socketio/rnd1/python-flask-socketio-4.2.1-1.fc31.src.rpm

Description: 
Flask-SocketIO --Socket.IO integration for Flask applications.

Fedora Account System Username: nonamedotc

COPR build: https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder4_rawhide/build/1134531/
Comment 1 Zbigniew Jędrzejewski-Szmek 2019-12-23 16:11:50 UTC 
Package name should not be repeated in %description. Expanding the %description
a bit would be nice too.

http://github.com/miguelgrinberg/Flask-SocketIO/ → https://

%description is repeated, defining it once as a macro using %{expand:} would  be nice.

%{python3_sitelib}/flask_socketio → %{python3_sitelib}/flask_socketio/

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK

Package is APPROVED.
Comment 2 Mukundan Ragavan 2019-12-23 21:48:03 UTC 
I will add the following description so that it is clear what the package is - "Flask-SocketIO gives Flask applications access to low latency bi-directional communications between the clients and the server. The client-side application can use any of the SocketIO official clients libraries in Javascript, C++, Java and Swift, or any compatible client to establish a permanent connection to the server." 

Taken from the docs.

Thanks for the review.
Comment 3 Gwyn Ciesla 2019-12-23 22:01:04 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-socketio