Bug 1814357

Summary:	Router e2e tests crash during upgrade from 4.1 due to un-migrated platform status field
Product:	OpenShift Container Platform	Reporter:	Dan Mace <dmace>
Component:	Networking	Assignee:	Dan Mace <dmace>
Networking sub component:	router	QA Contact:	Hongan Li <hongli>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	aos-bugs, dhansen, scuppett
Version:	4.4	Keywords:	Upgrades
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1815050 1817460 1830130 (view as bug list)		Environment:
Last Closed:	2020-05-20 18:36:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1815050, 1817460, 1830085, 1830130

Description Dan Mace 2020-03-17 17:26:12 UTC

Description of problem:

The router metrics and header tests can crash when migrating from an old version (e.g. 4.1) that has an un-migrated platform status field.

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly/22

Longer term the field should probably be backfilled/migrated during an upgrade. For now, code needs to account for the possibility of a nil platform status and fall back to the old deprecated field.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 4 Hongan Li 2020-03-26 02:20:38 UTC

In the previous e2e test: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly/22
we can find the error like:
[Conformance][Area:Networking][Feature:Router] The HAProxy router [Top Level] [Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal] expand_less	21s
fail [runtime/panic.go:199]: Test Panicked: runtime error: invalid memory address or nil pointer dereference

Checked latest e2e test https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly/30 and no this issue.