Bug 1814357 - Router e2e tests crash during upgrade from 4.1 due to un-migrated platform status field
Summary: Router e2e tests crash during upgrade from 4.1 due to un-migrated platform st...
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.4
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.4.0
Assignee: Dan Mace
QA Contact: Hongan Li
Depends On:
Blocks: 1815050 1817460 1830085 1830130
TreeView+ depends on / blocked
Reported: 2020-03-17 17:26 UTC by Dan Mace
Modified: 2022-08-04 22:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1815050 1817460 1830130 (view as bug list)
Last Closed: 2020-05-20 18:36:58 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift origin pull 24708 0 None closed Bug 1814357: Fix nil reference when accessing un-migrated platform status 2020-06-30 09:55:21 UTC
Github openshift origin pull 24718 0 None closed Bug 1814357: Fix another nil reference when accessing un-migrated platform status 2020-06-30 09:55:22 UTC

Description Dan Mace 2020-03-17 17:26:12 UTC
Description of problem:

The router metrics and header tests can crash when migrating from an old version (e.g. 4.1) that has an un-migrated platform status field.


Longer term the field should probably be backfilled/migrated during an upgrade. For now, code needs to account for the possibility of a nil platform status and fall back to the old deprecated field.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

Actual results:

Expected results:

Additional info:

Comment 4 Hongan Li 2020-03-26 02:20:38 UTC
In the previous e2e test: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly/22
we can find the error like:
[Conformance][Area:Networking][Feature:Router] The HAProxy router [Top Level] [Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal] expand_less	21s
fail [runtime/panic.go:199]: Test Panicked: runtime error: invalid memory address or nil pointer dereference

Checked latest e2e test https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly/30 and no this issue.

Note You need to log in before you can comment on or make changes to this bug.