Bug 1815050

Summary: Router e2e tests crash during upgrade from 4.1 due to un-migrated platform status field
Product: OpenShift Container Platform Reporter: Dan Mace <dmace>
Component: NetworkingAssignee: Dan Mace <dmace>
Networking sub component: router QA Contact: Hongan Li <hongli>
Status: CLOSED DUPLICATE Docs Contact:
Severity: high    
Priority: high CC: aos-bugs, dhansen, hongli
Version: 4.4   
Target Milestone: ---   
Target Release: 4.3.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1814357 Environment:
Last Closed: 2020-04-30 22:01:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1814357, 1817460, 1830130    
Bug Blocks:    

Description Dan Mace 2020-03-19 11:38:13 UTC
+++ This bug was initially created as a clone of Bug #1814357 +++

Description of problem:

The router metrics and header tests can crash when migrating from an old version (e.g. 4.1) that has an un-migrated platform status field.

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly/22

Longer term the field should probably be backfilled/migrated during an upgrade. For now, code needs to account for the possibility of a nil platform status and fall back to the old deprecated field.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from errata-xmlrpc on 2020-03-18 02:22:38 UTC ---

This bug has been added to advisory RHBA-2020:51809 by OpenShift Release Team Bot (ocp-build/buildvm.openshift.eng.bos.redhat.com)

--- Additional comment from errata-xmlrpc on 2020-03-18 02:22:39 UTC ---

Bug report changed to ON_QA status by Errata System.
A QE request has been submitted for advisory RHBA-2020:51809-01
https://errata.devel.redhat.com/advisory/51809

--- Additional comment from OpenShift Automated Release Tooling on 2020-03-19 00:40:30 UTC ---

Elliott changed bug status from ('MODIFIED',) to ON_QA.

Comment 1 Dan Mace 2020-03-25 19:10:24 UTC
Note the patch for this has been in-flight for 6 days, blocked on QE.

https://github.com/openshift/origin/pull/24721

Comment 4 Hongan Li 2020-04-03 04:13:00 UTC
Checked latest e2e test in https://testgrid.k8s.io/redhat-openshift-ocp-release-4.4-informing#release-openshift-origin-installer-e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly
didn't see the issue "invalid memory address or nil pointer dereference" any more.

Comment 5 Daneyon Hansen 2020-04-30 22:01:23 UTC

*** This bug has been marked as a duplicate of bug 1830130 ***