Bug 183889

Summary:	Review Request: perl-Crypt-Primes
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	kevin: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-19 07:00:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	175198, 183374
Bug Blocks:	163779, 183888

Description Paul Howarth 2006-03-03 13:34:52 UTC

Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-Primes/perl-Crypt-Primes.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-Primes/perl-Crypt-Primes-0.50-1.src.rpm
Description:

This module implements Ueli Maurer's algorithm for generating large provable
primes and secure parameters for public-key cryptosystems. The generated primes
are almost uniformly distributed over the set of primes of the specified
bitsize and expected time for generation is less than the time required for
generating a pseudo-prime of the same size with Miller-Rabin tests. Detailed
description and running time analysis of the algorithm can be found in Maurer's
paper, "Fast Generation of Prime Numbers and Secure Public-Key Cryptographic
Parameters" (1994).

Comment 1 Jason Tibbitts 2006-04-13 13:48:17 UTC

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   041947b9645142615d687b89cf2e1a7b  Crypt-Primes-0.50.tar.gz
   041947b9645142615d687b89cf2e1a7b  Crypt-Primes-0.50.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock.
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns no directories (besides %doc)
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Paul Howarth 2006-04-19 07:00:27 UTC

Thanks for the review.

 7837 (perl-Crypt-Primes): Build on target fedora-development-extras succeeded.
     Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-development-extras/7837-perl-Crypt-Primes-0.50-1.fc6/

Branchh requests for FC-4 and FC-5 made.

Comment 3 Paul Howarth 2008-06-23 20:12:25 UTC

Package Change Request
======================
Package Name: perl-Crypt-Primes
New Branches: EL-4 EL-5

Comment 4 Kevin Fenzi 2008-06-25 00:10:07 UTC

cvs done.