Bug 1867561

Summary:	Review Request: perl-MaxMind-DB-Common - Code shared by the MaxMind database reader and writer
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-MaxMind-DB-Common-0.040001-1.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-24 05:48:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1867617, 1867967

Description Petr Pisar 2020-08-10 11:31:21 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Common/perl-MaxMind-DB-Common.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Common/perl-MaxMind-DB-Common-0.040001-1.fc33.src.rpm
Description:
This distribution provides some shared code for use by both the MaxMind
database reader and writer Perl modules.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-21 09:52:40 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MaxMind-DB-Common-0.040001-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(autodie)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Data::Dumper::Concise)
      1 perl(DateTime)
      1 perl(Exporter)
      1 perl(List::AllUtils)
      1 perl(Math::BigInt)
      1 perl(MaxMind::DB::Types)
      1 perl(:MODULE_COMPAT_5.32.0) 
      1 perl(Moo)
      1 perl(Moo::Role)
      1 perl(MooX::StrictConstructor)
      1 perl(namespace::autoclean)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Quote)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-MaxMind-DB-Common-0.040001-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(MaxMind::DB::Common) = 0.040001
      1 perl-MaxMind-DB-Common = 0.040001-1.fc34
      1 perl(MaxMind::DB::Metadata) = 0.040001
      1 perl(MaxMind::DB::Role::Debugs) = 0.040001 
      1 perl(MaxMind::DB::Types) = 0.040001
      1 perl(Test::MaxMind::DB::Common::Data) = 0.040001
      1 perl(Test::MaxMind::DB::Common::Util) = 0.040001
Binary provides are Ok.

$ rpmlint ./perl-MaxMind-DB-Common*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 2 Petr Pisar 2020-08-21 10:22:06 UTC

https://pagure.io/releng/fedora-scm-requests/issue/27738

Comment 3 Gwyn Ciesla 2020-08-21 13:45:32 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MaxMind-DB-Common

Comment 4 Petr Pisar 2020-08-24 05:48:47 UTC

Thank you for the review and the repository.