Bug 1867561 - Review Request: perl-MaxMind-DB-Common - Code shared by the MaxMind database reader and writer
Summary: Review Request: perl-MaxMind-DB-Common - Code shared by the MaxMind database ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1867617 1867967
TreeView+ depends on / blocked
 
Reported: 2020-08-10 11:31 UTC by Petr Pisar
Modified: 2020-08-24 05:48 UTC (History)
2 users (show)

Fixed In Version: perl-MaxMind-DB-Common-0.040001-1.fc34
Clone Of:
Environment:
Last Closed: 2020-08-24 05:48:47 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-08-10 11:31:21 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Common/perl-MaxMind-DB-Common.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Common/perl-MaxMind-DB-Common-0.040001-1.fc33.src.rpm
Description:
This distribution provides some shared code for use by both the MaxMind
database reader and writer Perl modules.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-21 09:52:40 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MaxMind-DB-Common-0.040001-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(autodie)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Data::Dumper::Concise)
      1 perl(DateTime)
      1 perl(Exporter)
      1 perl(List::AllUtils)
      1 perl(Math::BigInt)
      1 perl(MaxMind::DB::Types)
      1 perl(:MODULE_COMPAT_5.32.0) 
      1 perl(Moo)
      1 perl(Moo::Role)
      1 perl(MooX::StrictConstructor)
      1 perl(namespace::autoclean)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Quote)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-MaxMind-DB-Common-0.040001-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(MaxMind::DB::Common) = 0.040001
      1 perl-MaxMind-DB-Common = 0.040001-1.fc34
      1 perl(MaxMind::DB::Metadata) = 0.040001
      1 perl(MaxMind::DB::Role::Debugs) = 0.040001 
      1 perl(MaxMind::DB::Types) = 0.040001
      1 perl(Test::MaxMind::DB::Common::Data) = 0.040001
      1 perl(Test::MaxMind::DB::Common::Util) = 0.040001
Binary provides are Ok.

$ rpmlint ./perl-MaxMind-DB-Common*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-08-21 13:45:32 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MaxMind-DB-Common

Comment 4 Petr Pisar 2020-08-24 05:48:47 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.