Bug 1867967 - Review Request: perl-MaxMind-DB-Reader-XS - Fast XS implementation of MaxMind DB reader
Summary: Review Request: perl-MaxMind-DB-Reader-XS - Fast XS implementation of MaxMind...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1867162 1867561 1867617
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-11 09:42 UTC by Petr Pisar
Modified: 2020-08-24 07:09 UTC (History)
2 users (show)

Fixed In Version: perl-MaxMind-DB-Reader-XS-1.000008-1.fc34
Clone Of:
Environment:
Last Closed: 2020-08-24 07:09:43 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-08-11 09:42:43 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Reader-XS/perl-MaxMind-DB-Reader-XS.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MaxMind-DB-Reader-XS/perl-MaxMind-DB-Reader-XS-1.000008-1.fc33.src.rpm
Description:
Simply installing this module causes MaxMind::DB::Reader to use the XS
implementation, which is much faster than the Perl implementation.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-08-21 14:20:30 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MaxMind-DB-Reader-XS-1.000008-1.fc34.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libmaxminddb.so.0()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit) 
      1 perl(Math::Int128)
      1 perl(Math::Int64)
      1 perl(MaxMind::DB::Metadata) >= 0.040001
      1 perl(MaxMind::DB::Reader::Role::HasMetadata)
      1 perl(MaxMind::DB::Types)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(Moo)
      1 perl(namespace::autoclean)
      1 perl(strict)
      1 perl(:VERSION) >= 5.10.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-MaxMind-DB-Reader-XS-1.000008-1.fc34.x86_64.rpm | sort | uniq -c
      1 perl(MaxMind::DB::Reader::XS) = 1.000008
      1 perl-MaxMind-DB-Reader-XS = 1.000008-1.fc34
      1 perl-MaxMind-DB-Reader-XS(x86-64) = 1.000008-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-MaxMind-DB-Reader-XS*
perl-MaxMind-DB-Reader-XS.x86_64: E: non-standard-executable-perm /usr/lib64/perl5/vendor_perl/auto/MaxMind/DB/Reader/XS/XS.so 555
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
TODO: Please check the permission

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-08-21 15:01:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MaxMind-DB-Reader-XS

Comment 4 Petr Pisar 2020-08-24 07:09:43 UTC
Thank you for the review and the repository.

The /usr/lib64/perl5/vendor_perl/auto/MaxMind/DB/Reader/XS/XS.so permissions should be corrected with %{_fixperms} call. Moreover it's a fresh file generated with a compiler. It should not inherit any bad mode. Also I cannot reproduce it. I suspect you build the package with Mock tool that recently suffered from a glibc bug meddling with mode checks everywhere. This transitional bug should be fixed now.


Note You need to log in before you can comment on or make changes to this bug.