Bug 189937

Summary: Review Request: unifdef
Product: [Fedora] Fedora Reporter: David Woodhouse <dwmw2>
Component: Package ReviewAssignee: David Cantrell <dcantrell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-04-26 16:16:21 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 188268, 190362    

Description David Woodhouse 2006-04-25 17:58:01 EDT
Spec URL: http://david.woodhou.se/unifdef.spec
SRPM URL: http://david.woodhou.se/unifdef-1.171-1.src.rpm
Description: 
Unifdef is useful for removing ifdefed lines from a file while otherwise
leaving the file alone. Unifdef acts on #ifdef, #ifndef, #else, and #endif
lines, and it knows only enough about C and C++ to know when one of these
is inactive because it is inside a comment, or a single or double quote.
Comment 1 David Woodhouse 2006-04-25 18:10:04 EDT
The plan is to use this when building the kernel package, which is why it's
proposed for Core, not Extras.
Comment 2 Jesse Keating 2006-04-25 18:10:46 EDT
I'll review this.
Comment 3 Jesse Keating 2006-04-26 10:31:36 EDT
Bad: 
- Source should be a URL to the source
- build root should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Good:
- rpmlint is silent.
- builds in mock for i386 / x86_64

Question:  How usable is this for kernel building right now?  There is some
pushback to not have it in Core until it is actually usable/needed to build the
kernel and that Extras would be a good place to put it until such time as it is
needed.  Your thoughts?
Comment 4 David Woodhouse 2006-04-26 10:58:19 EDT
The source was obtained from FreeBSD's cvsweb. You can have a CVS pserver URL,
or you can have the name of the tarball I prepared. I prefer the latter.

Fixed buildroot in 1.171-2


Comment 5 David Woodhouse 2006-04-26 11:01:39 EDT
I committed a change to the rawhide kernel this morning which uses the new 'make
headers_install' rules to generate kernel headers from the kernel tree. It's
conditional, and turned off right now because it BuildRequires unifdef, which we
don't have yet.
Comment 6 Jesse Keating 2006-04-26 11:11:20 EDT
Ah, good point about the source issue.  Everything else looks good now, passes
review.  Please follow the next steps on the PackageListProcess.
Comment 7 David Woodhouse 2006-04-26 16:16:21 EDT
Built in rawhide. Thanks.