Bug 1984198

Summary:	Review Request: rust-termwiz - Terminal Wizardry for Unix and Windows
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-03 04:26:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1984195, 1984196, 1984197, 2105831, 2105859, 2118892, 2138983
Bug Blocks:

Description Davide Cavalca 2021-07-20 23:10:31 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/rust-termwiz/rust-termwiz.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-termwiz/rust-termwiz-0.13.0-1.fc35.src.rpm

Description:
Terminal Wizardry for Unix and Windows.

Fedora Account System Username: dcavalca

Comment 1 Michel Lind 2022-01-15 04:46:11 UTC

LGTM, please upgrade to 0.15.0

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- X latest version of the crate is packaged - upgrade to termwiz 0.15.0
- license matches upstream specification (MIT) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Davide Cavalca 2022-01-15 04:52:35 UTC

Thanks!

$ fedpkg request-repo rust-termwiz 1984198
https://pagure.io/releng/fedora-scm-requests/issue/40980

Comment 3 Jens Petersen 2022-01-16 06:08:58 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-termwiz

Comment 4 Davide Cavalca 2022-07-10 22:09:22 UTC

This was imported but never built properly. I tried updating it to 0.16.0 to see if that helps, but it requires two new crates: wezterm-bidi and wezterm-color-types.

Comment 5 Davide Cavalca 2022-10-31 20:54:29 UTC

0.18.0 grew one more dep: https://bugzilla.redhat.com/show_bug.cgi?id=2138983

Comment 6 Fabio Valentini 2022-11-02 20:21:14 UTC

Just package the previous version for now, the finl_unicode review might take some time - looks like it bundles large amounts of code generated from Unicode data but doesn't specify this correctly.

Comment 7 Fedora Update System 2022-11-03 04:25:55 UTC

FEDORA-2022-59e1a826f8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-59e1a826f8

Comment 8 Fedora Update System 2022-11-03 04:26:29 UTC

FEDORA-2022-59e1a826f8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.