Bug 2032554
| Summary: | [RFE:EPEL9] EPEL9 branch for pre-commit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Pat Riehecky <riehecky> |
| Component: | pre-commit | Assignee: | Ben Beasley <code> |
| Status: | CLOSED ERRATA | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel9 | CC: | aniketpradhan1999, chedi.toueiti, code, ego.cordatus, mkfedora, psplicha, python-sig |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | pre-commit-3.3.3-1.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-03 01:52:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2032643, 2032644, 2032645, 2134200 | ||
| Bug Blocks: | |||
|
Description
Pat Riehecky
2021-12-14 17:14:45 UTC
I myself am not interested in this endeavor. Will you be able to branch and build pre-commit in epel9? Ignoring the question for now of whether anyone is willing to maintain this, there are still some dependency issues blocking an EPEL9 backport. - One can drop the BuildRequires on luarocks and skip any tests that require it, since this is only for Lua support. - One can drop the BuildRequires on rubypick and skip any tests that require it, since this is only for Ruby support. - One can drop the BuildRequires on python3dist(nodeenv) >= 0.11.1 and skip any tests that require it, since this is only for NodeJS support. - One can patch out the BuildRequires on python3dist(re-assert) and skip any tests that require it, since it is used only for tests, and most of the tests don’t need it. What’s left are the following truly mandatory dependencies: > No matching package to install: 'python3dist(cfgv) >= 2' (bug 2032645) > No matching package to install: 'python3dist(identify) >= 1' (bug 2032643) *** Bug 2152746 has been marked as a duplicate of this bug. *** > What’s left are the following truly mandatory dependencies:
>
> > No matching package to install: 'python3dist(cfgv) >= 2'
> (bug 2032645)
> > No matching package to install: 'python3dist(identify) >= 1'
> (bug 2032643)
Both above-mentioned dependencies should now be in stable repos.
(In reply to Petr Šplíchal from comment #5) > > What’s left are the following truly mandatory dependencies: > > > > > No matching package to install: 'python3dist(cfgv) >= 2' > > (bug 2032645) > > > No matching package to install: 'python3dist(identify) >= 1' > > (bug 2032643) > > Both above-mentioned dependencies should now be in stable repos. Thanks. I guess I missed in the previous analysis that nodeenv>=0.11.1 is required at install time. I suppose one could patch it out, thereby breaking node support, but let me see if I can help the maintainer patch out the deprecated python-mock dependency and get it into EPEL9 instead. I have offered a PR to update python-nodeenv to the current version: https://src.fedoraproject.org/rpms/python-nodeenv/pull-request/2 It removes the dependency on the deprecated python-mock package; if merged, python-nodeenv can be branched for EPEL9 without further changes. If python-nodeenv is branched for EPEL9, the current pre-commit spec file from Rawhide can also be branched for EPEL9 without further changes. (All of the dependencies that I said would have to be patched out are now available, and the tests pass in a local mock build.) Ben, thank you very much for moving this forward! Nice, python-nodeenv for el9 is now in the stable repo: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-901fc40f3f It looks like the Rawhide spec file still works for EPEL9. I’m going to go ahead and request the branch. FEDORA-EPEL-2023-6ab9066c39 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6ab9066c39 FEDORA-EPEL-2023-6ab9066c39 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6ab9066c39 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2023-6ab9066c39 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6ab9066c39 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2023-6ab9066c39 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |